Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create route documentation #753

Merged
merged 2 commits into from
Jan 17, 2024
Merged

create route documentation #753

merged 2 commits into from
Jan 17, 2024

Conversation

Sheng-Long
Copy link
Contributor

Description:
Create routing documentation similar to a swagger doc

Related issue(s):

Fixes # 445

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 87.56% 33336 / 38068
🔵 Statements 87.56% 33336 / 38068
🔵 Functions 66.44% 800 / 1204
🔵 Branches 84.62% 3776 / 4462
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/router.ts 89.92% 34.48% 62.5% 89.92% 119-122, 227-230, 265, 281-282, 284-285, 287-288, 290-291, 293-294, 296-297, 299-300, 302-303, 305-306, 308-309, 311-312, 314-315, 317, 339-340, 374, 383-384
src/components/Property.vue 100% 80% 100% 100%
src/pages/RoutingSpec.vue 37.99% 100% 0% 37.99% 78-250
Generated in workflow #635

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
63.6% 63.6% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@SimiHunjan SimiHunjan linked an issue Nov 16, 2023 that may be closed by this pull request
Define APIs to for the search feature in the mirror node explorer #445
Closed
@Sheng-Long
create route documentation
c652775 
Signed-off-by: Tim Schmidt <tim@launchbadge.com>
@Sheng-Long
fix: remove some routes
a43ad0c 
Signed-off-by: Tim Schmidt <tim@launchbadge.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
54.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

svienot
svienot approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svienot svienot merged commit 5d9fad1 into main Jan 17, 2024
6 of 7 checks passed
@svienot svienot deleted the 00445-routingDoc branch January 17, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

@ericleponner ericleponner Awaiting requested review from ericleponner ericleponner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define APIs to for the search feature in the mirror node explorer
3 participants
@Sheng-Long @svienot @ericleponner