feat: add toggle in Recent Contracts to display only verified contracts #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
… VerifiedContractsTable and VerifiedContractsController renamed respectively AccountVerifiedContractsTable and AccountVerifiedContractsController. Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
…Lookup and SingletonLookup classes as Lookup interface. Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
…for VerifiedContractsCache. Signed-off-by: Simon Viénot <simon.vienot@icloud.com> Make VerifiedContractsBuffer capacity configurable. Use capacity 500 for VerifiedContractsCache. Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Provide functionality similar to what is already available in AccountDetails for recent created contract: add a toggle allowing to choose between
Allcontracts andVerifiedcontracts.Since the Sourcify server does not provide a sorted/paginated enumeration of verified contracts, we have to get from mirror-node a fixed size buffer of the most recent contracts created, among which we filter verified contracts, if any.
Some refactoring was done to share
VerifiedContractsTableandVerifiedContractsControllerbetween theContractsandAccountDetailsviews. Only the cache differs (respectivelyVerifiedContractsCacheandVerifiedContractsByAccountIdCache)To allow for this, the corresponding Lookup classes, resp.
SingletonLookupandEntityLookup(renamed fromLookup) are now implementing a commonLookupinterface.Related issue(s):
Fixes #884
Notes for reviewer:
Being deployed on staging server.
Checklist