Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Explorer search bar reject domain name expressed in uppercases #926

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix: Explorer search bar reject domain name expressed in uppercases #926

merged 2 commits into from
Mar 11, 2024

Conversation

ericleponner
Copy link
Collaborator

@ericleponner ericleponner commented Mar 11, 2024 •
edited
Loading

Description:

Changes below fix regular expression used by SearchRequest.run() to accept domain names.
run method now accepts domain in uppercases and sends them for resolution to KNS and HNS.
Changes also add an extra test case in SearchBar.cy.ts to check that scenario.

Related issue(s):

Fixes #925

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner
SearchRequest.run() now accepts domain name expressed with uppercases.
d43171c 
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.2% 35411 / 42561
🔵 Statements 83.2% 35411 / 42561
🔵 Functions 64.13% 835 / 1302
🔵 Branches 84.12% 3905 / 4642
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/SearchRequest.ts 91.68% 80% 100% 91.68% 123-129, 141-142, 163-166, 195-197, 203-204, 224-225, 307-310, 347-348, 351-352, 357-358
Generated in workflow #766

@ericleponner
SearchBar.cy.ts now checks that Explorer resolves domain names expres…
c34dc59 
…sed with upper cases.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ericleponner ericleponner marked this pull request as ready for review March 11, 2024 19:17
svienot
svienot approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericleponner ericleponner merged commit 883ac56 into main Mar 11, 2024
6 of 7 checks passed
@ericleponner ericleponner deleted the 00925_uppercased_domain branch March 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explorer search bar reject domain name expressed in uppercases
2 participants
@ericleponner @svienot