Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed "Show Raw Data" link from topic details view #930

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below remove Show Raw Data link from topic details.
Mirror node does not expose topic entity (it only provides topic message).
Thus there is no way to provide Show Raw Data action like in other detail pages.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.19% 35409 / 42559
🔵 Statements 83.19% 35409 / 42559
🔵 Functions 64.13% 835 / 1302
🔵 Branches 84.16% 3912 / 4648
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/TopicDetails.vue 100% 87.5% 100% 100%
Generated in workflow #772

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ericleponner ericleponner merged commit a3a9958 into main Mar 18, 2024
7 checks passed
@ericleponner ericleponner deleted the no_show_row_data_for_topics branch March 18, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants