Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00856 add hip 859 support for gasconsumed #931

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

quiet-node
Copy link
Member

Description:
This PR adds a new field Gas Consumed under contract result information section to introduce the support for HIP-859

image

Fixes #856

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added enhancement New feature or request P1 An issue impacting production environments or impacting multiple releases or multiple individuals smart contracts Features that involve smart contracts labels Mar 18, 2024
@quiet-node quiet-node self-assigned this Mar 18, 2024
@quiet-node quiet-node linked an issue Mar 18, 2024 that may be closed by this pull request
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 00856-add-hip-859-support-for-gasconsumed branch from 83a5311 to e79899d Compare March 18, 2024 14:37
@ericleponner ericleponner self-requested a review March 18, 2024 14:38
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.2% 35416 / 42566
🔵 Statements 83.2% 35416 / 42566
🔵 Functions 64.13% 835 / 1302
🔵 Branches 84.16% 3913 / 4649
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/contract/ContractResult.vue 100% 89.28% 100% 100%
src/schemas/HederaSchemas.ts 97.92% 64.28% 100% 97.92% 296-297, 665, 789-790, 792-793, 809-810, 812-819
Generated in workflow #774

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@quiet-node quiet-node merged commit 045876a into main Mar 18, 2024
7 checks passed
@quiet-node quiet-node deleted the 00856-add-hip-859-support-for-gasconsumed branch March 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 An issue impacting production environments or impacting multiple releases or multiple individuals smart contracts Features that involve smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP-859 support for gasConsumed
2 participants