Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display hint when wallet is silent #949

Merged
merged 6 commits into from
Mar 27, 2024
Merged

fix: display hint when wallet is silent #949

merged 6 commits into from
Mar 27, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Mar 27, 2024

Description:

  • Adresses the issue by adding a couple hints for the user, to the existing error message.
  • Also refactors the dialog implementation to use the new dialog components.

Related issue(s):

Fixes #895

Notes for reviewer:

  • See related issue for reproducing the issue.
  • New dialog with hints:
Screenshot 2024-03-27 at 11 47 34

@svienot
Improve error message when wallet is silent to provide hints to the u…
64a0f47 
…ser.

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Allow to force display of success/error icon in DialogStatus (for fur…
09c9c6c 
…ther use).

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Add ConnectWalletDialog (for further use).
b2f4c9b 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Use ConnectWalletDialog (based on new Dialog components) instead of P…
e89948c 
…rogressDialog in TopNavBar.

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Adjust unit tests to new WalletConnectionDialog.
1495781 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot svienot self-assigned this Mar 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.91% 37689 / 45453
🔵 Statements 82.91% 37689 / 45453
🔵 Functions 62.35% 853 / 1368
🔵 Branches 84.24% 3978 / 4722
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/TopNavBar.vue 84.77% 94.11% 63.63% 84.77% 2-47, 209-213, 223-224
src/components/dialog/DialogStatus.vue 83.87% 100% 0% 83.87% 69-83
src/components/wallet/ConnectWalletDialog.vue 96.11% 100% 100% 96.11% 81-82, 86-87
src/utils/wallet/WalletDriver.ts 69.91% 100% 14.28% 69.91% 35-36, 39-40, 43-44, 47-48, 51-52, 61-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-96
Generated in workflow #788

@svienot
Get rid of import no longer needed in TopNavBar.
d27cf7c 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

ericleponner
ericleponner approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericleponner ericleponner merged commit b0f0337 into main Mar 27, 2024
6 of 7 checks passed
@ericleponner ericleponner deleted the 00895-display-hint-when-wallet-is-silent branch March 27, 2024 17:16
@ericleponner ericleponner mentioned this pull request Jul 8, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees

@svienot svienot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error connecting to Hashpack
2 participants
@svienot @ericleponner