Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: too many nested calls break call trace depth path. #950

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: too many nested calls break call trace depth path. #950

merged 1 commit into from
Mar 28, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Mar 27, 2024

Description:

Truncate the call trace depth path when nesting level > 20.

Related issue(s):

Fixes #916

Notes for reviewer:

Screenshot 2024-03-27 at 19 59 13

@svienot
Truncate contract call trace depth path when too many nested levels.
cc02a80 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot svienot self-assigned this Mar 27, 2024
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.91% 37693 / 45459
🔵 Statements 82.91% 37693 / 45459
🔵 Functions 62.35% 853 / 1368
🔵 Branches 84.22% 3979 / 4724
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/contract/ContractActionsLoader.ts 89.65% 79.16% 83.33% 89.65% 71-76, 92-93, 100-101, 110-111
Generated in workflow #789

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ericleponner
ericleponner approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ericleponner ericleponner merged commit f7ea7d0 into main Mar 28, 2024
7 checks passed
@ericleponner ericleponner deleted the 00916-too-many-nested-calls branch March 28, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees

@svienot svienot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executing a contractCall transaction with a function with many nested calls breaks the CallTrace UI
2 participants
@svienot @ericleponner