Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flag call signature decoded with 4byte.directory #951

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below add a "4byte" pills in Call Result and Call Trace sections when a signature has been resolved using 4byte.directory database.

Notes for reviewer:

image

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

ericleponner and others added 4 commits March 28, 2024 10:01
…m 4byte.directory.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.91% 37708 / 45478
🔵 Statements 82.91% 37708 / 45478
🔵 Functions 62.35% 853 / 1368
🔵 Branches 84.21% 3975 / 4720
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/values/SignatureValue.vue 88.88% 100% 0% 88.88% 64-72
src/utils/analyzer/FunctionCallAnalyzer.ts 94.48% 81.63% 100% 94.48% 106, 166, 197, 228-229, 246-249, 253, 260-261, 268-271, 326-328, 362-363
Generated in workflow #790

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ericleponner ericleponner merged commit b893cf0 into main Mar 28, 2024
6 of 7 checks passed
@ericleponner ericleponner deleted the flag_4byte branch March 28, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants