Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jar name & bump to v0.31.0-alpha3 #1786

Merged
merged 7 commits into from
Mar 30, 2021
Merged

Fix jar name & bump to v0.31.0-alpha3 #1786

merged 7 commits into from
Mar 30, 2021

Conversation

steven-sheehy
Copy link
Member

Detailed description:

  • Fix Rosetta validation failing on tags
  • Fix release jar not prefixed with v
  • Bump versions to v0.31.0-alpha3

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@steven-sheehy
Fix jar name and bump to v0.31.0-alpha3
6ba14fa 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy
Bump versions to v0.31.0-alpha3
b16e037 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 process Build or test related tasks labels Mar 30, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.31.0 milestone Mar 30, 2021
@steven-sheehy steven-sheehy requested a review from a team March 30, 2021 22:20
@steven-sheehy steven-sheehy self-assigned this Mar 30, 2021
Nana-EC
Nana-EC previously approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited
Loading

Codecov Report

Merging #1786 (92703ac) into master (1a591a2) will not change coverage.
The diff coverage is n/a.

❗ Current head 92703ac differs from pull request most recent head a3d28f6. Consider uploading reports for the commit a3d28f6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1786   +/-   ##
=========================================
  Coverage     87.36%   87.36%           
+ Complexity     1737     1736    -1     
=========================================
  Files           315      315           
  Lines          7676     7676           
  Branches        732      732           
=========================================
  Hits           6706     6706           
  Misses          740      740           
  Partials        230      230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a591a2...a3d28f6. Read the comment docs.

ijungmann
ijungmann previously approved these changes Mar 30, 2021
View reviewed changes
@steven-sheehy
Fix Rosetta validation
5e7e28d 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy dismissed stale reviews from ijungmann and Nana-EC via 5e7e28d March 30, 2021 22:46
@steven-sheehy
Another attempt
635b66b 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy
Attempt #3
fd2070d 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy
Attempt #4
864acd2 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy
Attempt #5
a3d28f6 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.9% 76.9% Coverage
0.0% 0.0% Duplication

xin-hedera
xin-hedera approved these changes Mar 30, 2021
View reviewed changes
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 0fc757c into master Mar 30, 2021
@steven-sheehy steven-sheehy deleted the fix-jar-name branch March 30, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xin-hedera xin-hedera xin-hedera approved these changes

@Nana-EC Nana-EC Nana-EC left review comments

@ijungmann ijungmann ijungmann left review comments

Assignees

@steven-sheehy steven-sheehy

Labels
bug Type: Something isn't working P1 process Build or test related tasks
Projects
None yet
Milestone
Mirror 0.31.0
Development

Successfully merging this pull request may close these issues.
4 participants
@steven-sheehy @ijungmann @Nana-EC @xin-hedera