Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max execution time setter for NodeChannel GRPC #1354

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Dec 13, 2022

Description:
Added timeout setter in NodeChannel._createUnaryClient.

Related issue(s):

Fixes #1276

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 83.54% // Head: 83.54% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (6027020) compared to base (dfc5c87).
Patch coverage: 86.36% of modified lines in pull request are covered.

❗ Current head 6027020 differs from pull request most recent head 48695af. Consider uploading reports for the commit 48695af to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1354      +/-   ##
===========================================
- Coverage    83.54%   83.54%   -0.01%     
===========================================
  Files          292      292              
  Lines        72854    72871      +17     
===========================================
+ Hits         60864    60878      +14     
- Misses       11990    11993       +3     
Impacted Files Coverage Δ
src/client/NodeClient.js 82.12% <81.25%> (-0.11%) ⬇️
src/PrivateKey.js 92.09% <100.00%> (ø)
src/channel/NodeChannel.js 97.43% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: ochikov <ognyan@limechain.tech>
@ochikov ochikov force-pushed the enhancement/max-execution-time branch from ff51544 to 48695af Compare December 13, 2022 13:06
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@petreze petreze merged commit cc1d431 into develop Dec 13, 2022
@petreze petreze deleted the enhancement/max-execution-time branch December 13, 2022 14:12
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
Signed-off-by: ochikov <ognyan@limechain.tech>

Signed-off-by: ochikov <ognyan@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable timeout period for GrpcServicesError in NodeChannel
2 participants