Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize toJson functionality #1880

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Sep 15, 2023

Description:
Finalize toJson functionality in TransactionResponse, TransactionReceipt and TransactionRecord

Related issue(s):

Fixes #1855

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ochikov ochikov merged commit 536f38e into develop Sep 15, 2023
9 of 10 checks passed
@ochikov ochikov deleted the fix/stringify-objects-in-tojson branch September 15, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a toJson method on receipt and record which is consistent across all SDKs
2 participants