Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setDefaultMaxQueryPayment() and deprecate setMaxQueruPayment() #1897

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Sep 25, 2023

Description:

Deprecating setMaxQueryPayment() method in a favor of setDefaultMaxQueryPayment() method.
Deprecating setMaxTransactionFee() method in a favor of setDefaultMaxTransactionFee() method.

Related issue(s): #1297

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the fix/1297-add-setDefaultMaxQueryPayment-and-deprecate-setMaxQueryPayment branch from 9c1b598 to 85caa9d Compare September 26, 2023 06:05
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 941 lines in your changes are missing coverage. Please review.

Comparison is base (cab7be2) 76.94% compared to head (3e36a4c) 77.04%.
Report is 136 commits behind head on develop.

❗ Current head 3e36a4c differs from pull request most recent head 85caa9d. Consider uploading reports for the commit 85caa9d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1897      +/-   ##
===========================================
+ Coverage    76.94%   77.04%   +0.10%     
===========================================
  Files          292      265      -27     
  Lines        72743    66206    -6537     
===========================================
- Hits         55971    51010    -4961     
+ Misses       16772    15196    -1576     
Files Coverage Δ
src/BadEntityIdError.js 71.42% <100.00%> (ø)
src/Duration.js 100.00% <100.00%> (+3.03%) ⬆️
src/EthereumTransaction.js 60.44% <100.00%> (-32.92%) ⬇️
src/ExchangeRates.js 62.35% <100.00%> (ø)
src/FeeComponents.js 29.85% <100.00%> (ø)
src/FeeData.js 44.27% <100.00%> (ø)
src/FeeDataType.js 69.10% <100.00%> (-25.21%) ⬇️
src/FeeSchedule.js 53.84% <100.00%> (ø)
src/FeeSchedules.js 57.89% <100.00%> (ø)
src/FreezeType.js 70.99% <100.00%> (ø)
... and 175 more

... and 90 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petreze petreze merged commit ebc3781 into develop Oct 3, 2023
10 checks passed
@petreze petreze deleted the fix/1297-add-setDefaultMaxQueryPayment-and-deprecate-setMaxQueryPayment branch October 3, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setDefaultMaxQueryPayment() and deprecate setMaxQueruPayment()
3 participants