Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fromStringDer() method (and tests) and deprecated fromString() method #2030

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Nov 16, 2023

Description:

  • deprecated fromString() method to prevent future confusion
  • regardless of the method being deprecated, a warning message was added that suggests the developer use one of the other methods
  • added a new fromStringDer() method that is used for a HEX-encoded string with a DER prefix for developer convenience
  • tests for fromStringDer() method

Related issue(s):

Fixes #2027

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ng method

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ff951ea) 76.12% compared to head (8aa887e) 83.79%.
Report is 3 commits behind head on develop.

❗ Current head 8aa887e differs from pull request most recent head 9ac9622. Consider uploading reports for the commit 9ac9622 to get more accurate results

Files Patch % Lines
src/LocalProvider.js 71.42% 2 Missing ⚠️
src/constants/ClientConstants.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2030      +/-   ##
===========================================
+ Coverage    76.12%   83.79%   +7.66%     
===========================================
  Files          304      304              
  Lines        75854    75861       +7     
===========================================
+ Hits         57746    63569    +5823     
+ Misses       18108    12292    -5816     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@svetoslav-nikol0v svetoslav-nikol0v merged commit 25880cc into develop Nov 20, 2023
10 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2027-hts-or-the-sdk-treat-ed25519-private-keys-preferentially-over-ecdsa-private-keys branch November 20, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTS or the SDK treat Ed25519 private keys preferentially over ECDSA private keys
2 participants