New web proxy for nodeAccountId 3 #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
svetoslav-nikol0v
requested review from
SimiHunjan,
ochikov and
petreze
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2051 +/- ##
===========================================
+ Coverage 84.16% 84.29% +0.12%
===========================================
Files 304 304
Lines 75863 75874 +11
===========================================
+ Hits 63852 63958 +106
+ Misses 12011 11916 -95 ☔ View full report in Codecov by Sentry. |
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
rokn
reviewed
Dec 5, 2023
| it(`should fetch ${MAINNET[proxy]} account balnace`, async function () { | ||
| const accountBalance = await new AccountBalanceQuery() | ||
| .setNodeAccountIds([MAINNET[proxy]]) | ||
| .setAccountId(env.operatorId) |
There was a problem hiding this comment.
I think we should use a known account like 0.0.3 for checking the balance as we might run into some problems if the operator account id doesn't exist on all networks
rokn
approved these changes
Dec 5, 2023
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
|
Kudos, SonarCloud Quality Gate passed!
|
svetoslav-nikol0v
deleted the
2028-add-swirlds-labs-web-proxy-for-node-account-id-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a new web proxy for node account ID 3.
Related issue(s):
Fixes #2028
Checklist