Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: serialize and deserialize an incompleted transaction #2067

Merged
merged 28 commits into from
Feb 12, 2024
Merged

feature: serialize and deserialize an incompleted transaction #2067

merged 28 commits into from
Feb 12, 2024

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Dec 19, 2023 •
edited
Loading

Description:

Serialize and deserialize an incompleted transactions (HIP-745).

Fixes #1808 #1807

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (cb01e23) 76.24% compared to head (cb3333c) 77.86%.
Report is 2 commits behind head on develop.

Files Patch % Lines
src/transaction/Transaction.js 65.69% 59 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2067      +/-   ##
===========================================
+ Coverage    76.24%   77.86%   +1.61%     
===========================================
  Files          305      266      -39     
  Lines        76104    66735    -9369     
===========================================
- Hits         58027    51962    -6065     
+ Misses       18077    14773    -3304

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Petyo-Lukanov Petyo-Lukanov linked an issue Feb 1, 2024 that may be closed by this pull request
Add HIP-745: Optionally send transaction data without required transaction fields #1807
Closed
@svetoslav-nikol0v
serialize/deserialize unsigned transactions
fbb6e6b 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
tests
26c24e3 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
fixed tests
eb9b43c 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
adding additional checks
f1234b2 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
examples
d9ab30f 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
format latest changes
681918b 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
update examples
baaa454 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
create as many transaction copies as there are account ids if they ar…
082c7b6 
…e set

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
create type that includes all transactions types
882eaea 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
set transactionID or nodeAccountID in incompleted transaction
3f5d576 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
remove unnecessary function
fe7bf91 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
update tests
cb3333c 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
add setLogger method in LocalProvider class
747695d 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
add more examples
c3c6b0a 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
fix
a33328d 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
update examples
8eb80e6 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
add integration tests
68a17b4 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
remove unit test
2c3e7fe 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
add wallet to integration test env
0335840 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
add additional check for fileMemo prop
d5c39da 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
Merge branch 'develop' into hip-745
1e78b47 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v svetoslav-nikol0v marked this pull request as ready for review February 8, 2024 15:05
@svetoslav-nikol0v svetoslav-nikol0v changed the title HIP-745 feature: Create an incompleted transaction Feb 8, 2024
@svetoslav-nikol0v svetoslav-nikol0v changed the title feature: Create an incompleted transaction feature: create an incompleted transaction Feb 8, 2024
@svetoslav-nikol0v svetoslav-nikol0v changed the title feature: create an incompleted transaction feature: serialize and deserialize an incompleted transaction Feb 8, 2024
@svetoslav-nikol0v
fix
54309d0 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
declare variable
c7c4a15 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024 •
edited
Loading

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (4851721) 77.92% compared to head (784d11f) 84.21%.

❗ Current head 784d11f differs from pull request most recent head e3076be. Consider uploading reports for the commit e3076be to get more accurate results

Files Patch % Lines
src/transaction/Transaction.js 73.54% 41 Missing ⚠️
src/LocalProvider.js 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2067      +/-   ##
===========================================
+ Coverage    77.92%   84.21%   +6.29%     
===========================================
  Files          266      305      +39     
  Lines        66595    76250    +9655     
===========================================
+ Hits         51894    64216   +12322     
+ Misses       14701    12034    -2667

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svetoslav-nikol0v
fix
6c1d137 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
update address book
784d11f 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
agadzhalov
agadzhalov approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svetoslav-nikol0v
remove custom type definition
b8a0945 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
fix warning related to the examples
97516fc 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v
tests descriptions
e3076be 
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@svetoslav-nikol0v svetoslav-nikol0v merged commit 8210a60 into develop Feb 12, 2024
6 of 7 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the hip-745 branch February 12, 2024 09:28
@hedera-eng-infrastructure hedera-eng-infrastructure mentioned this pull request Jun 16, 2024
Open
@hedera-eng-infrastructure hedera-eng-infrastructure mentioned this pull request Jun 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agadzhalov agadzhalov agadzhalov approved these changes

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan

@ochikov ochikov Awaiting requested review from ochikov

@petreze petreze Awaiting requested review from petreze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HIP-745: Design feature Add HIP-745: Optionally send transaction data without required transaction fields
3 participants
@svetoslav-nikol0v @codecov-commenter @agadzhalov