Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: handle PLATFORM_NOT_ACTIVE error gracefully #2401

Merged

Conversation

svetoslav-nikol0v
Copy link
Contributor

Description:

When the SDK gets PLATFORM_NOT_ACTIVE error, will retry to execute the transaction until reaching the max attempts limit.

Fixes #2353

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.37%. Comparing base (5c428d4) to head (9969daf).
Report is 90 commits behind head on main.

Files Patch % Lines
src/transaction/TransactionRecordQuery.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2401      +/-   ##
==========================================
- Coverage   76.49%   74.37%   -2.13%     
==========================================
  Files         304      269      -35     
  Lines       75800    67837    -7963     
==========================================
- Hits        57986    50455    -7531     
+ Misses      17814    17382     -432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jul 18, 2024

@svetoslav-nikol0v svetoslav-nikol0v marked this pull request as ready for review July 18, 2024 11:54
@svetoslav-nikol0v svetoslav-nikol0v requested review from a team as code owners July 18, 2024 11:54
@svetoslav-nikol0v svetoslav-nikol0v requested review from rwalworth and agadzhalov and removed request for rwalworth July 18, 2024 11:54
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle platform_not_active error gracefully
2 participants