feat: Add removeSignature/clearAllSignatures methods #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivaylogarnev-limechain
requested review from
rwalworth,
agadzhalov and
ivaylonikolov7
ivaylogarnev-limechain
force-pushed
the
feat/2461-remove-clear-signatures
branch
from
5adbfda
to
6607bd9
Compare
… class, wrote some unit tests for both Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
force-pushed
the
feat/2461-remove-clear-signatures
branch
from
6607bd9
to
0828c1d
Compare
…d throwing an error if trying to remove non-existing signature Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
force-pushed
the
feat/2461-remove-clear-signatures
branch
2 times, most recently
from
20136c7
to
1ecb4ed
Compare
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
…gment Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
force-pushed
the
feat/2461-remove-clear-signatures
branch
from
1ecb4ed
to
af34748
Compare
…movedSignatures and wrote tests for both Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
0xivanov
reviewed
Aug 29, 2024
jbair06
reviewed
Aug 29, 2024
jbair06
reviewed
Aug 29, 2024
jbair06
reviewed
Aug 29, 2024
… adjusted the logic, renamed clearAllSignatures and changed the return type, adjusted some tests Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
This was referenced Sep 3, 2024
ivaylogarnev-limechain
force-pushed
the
feat/2461-remove-clear-signatures
branch
from
e4652ea
to
10525e9
Compare
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
force-pushed
the
feat/2461-remove-clear-signatures
branch
from
10525e9
to
81245d0
Compare
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
…some methods conditions Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
…tests and examples for the multi-node flow Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
…o examples Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Signed-off-by: ivaylogarnev <ivaylo.garnev@limechain.tech>
ivaylonikolov7
previously approved these changes
Sep 20, 2024
Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
dismissed stale reviews from agadzhalov and ivaylonikolov7
via
a79edd5
…aph/hedera-sdk-js into feat/2461-remove-clear-signatures Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
force-pushed
the
feat/2461-remove-clear-signatures
branch
from
a79edd5
to
c5e7d1e
Compare
|
agadzhalov
approved these changes
Sep 20, 2024
ivaylogarnev-limechain
deleted the
feat/2461-remove-clear-signatures
branch
b-l-u-e
pushed a commit
to b-l-u-e/hedera-sdk-js
that referenced
this pull request
Oct 13, 2024
* feat: Added removeSignature/clearAllSignatures methods to Transaction class, wrote some unit tests for both Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * feat: Added more unit tests for removeSignature/clearAllSignatures and throwing an error if trying to remove non-existing signature Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Turned signAndAddSignatures function into arrow Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Cleared some unnecessary comments and changed variable assigment Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * feat: Enhancement removeSignature/clearAllSignatures to return the removedSignatures and wrote tests for both Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Removed the signature param from removeSignature method and adjusted the logic, renamed clearAllSignatures and changed the return type, adjusted some tests Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Remove redundant code Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * Merge branch 'main' into feat/2461-remove-clear-signatures Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Cleared some uneccessary comments & changed a bit the flow some methods conditions Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * Merge branch main into feat/2461-remove-clear-signatures Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Refactored signTransaction method a bit, added integration tests and examples for the multi-node flow Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Removed duplicate integration tests and added description to examples Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Examples pre-release warnings fixes Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> --------- Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> Signed-off-by: ivaylogarnev <ivaylo.garnev@limechain.tech> Co-authored-by: ivaylonikolov7 <ivaylo.nikolov@limechain.tech> Signed-off-by: b-l-u-e <winnie.gitau282@gmail.com>
b-l-u-e
pushed a commit
to b-l-u-e/hedera-sdk-js
that referenced
this pull request
Oct 13, 2024
* feat: Added removeSignature/clearAllSignatures methods to Transaction class, wrote some unit tests for both Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * feat: Added more unit tests for removeSignature/clearAllSignatures and throwing an error if trying to remove non-existing signature Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Turned signAndAddSignatures function into arrow Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Cleared some unnecessary comments and changed variable assigment Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * feat: Enhancement removeSignature/clearAllSignatures to return the removedSignatures and wrote tests for both Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Removed the signature param from removeSignature method and adjusted the logic, renamed clearAllSignatures and changed the return type, adjusted some tests Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Remove redundant code Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * Merge branch 'main' into feat/2461-remove-clear-signatures Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Cleared some uneccessary comments & changed a bit the flow some methods conditions Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * Merge branch main into feat/2461-remove-clear-signatures Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Refactored signTransaction method a bit, added integration tests and examples for the multi-node flow Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Removed duplicate integration tests and added description to examples Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * refactor: Examples pre-release warnings fixes Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> --------- Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> Signed-off-by: ivaylogarnev <ivaylo.garnev@limechain.tech> Co-authored-by: ivaylonikolov7 <ivaylo.nikolov@limechain.tech> Signed-off-by: b-l-u-e <winnie.gitau282@gmail.com>
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces the removeSignature and clearAllSignatures methods, allowing transactions to manage signatures more flexibly. Specifically, these methods enable the removal of individual signatures or the clearing of all signatures from a transaction after they have been added and signed.
Related issue(s):
#2461
Checklist