feat: Changed the return type of removeAllSignatures method #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction class and fixed unit and integration related tests Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
requested review from
rwalworth,
ivaylonikolov7,
0xivanov,
agadzhalov and
gsstoykov
…icKey method Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
changed the title
Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2559 +/- ##
==========================================
- Coverage 84.50% 78.23% -6.27%
==========================================
Files 283 283
Lines 71021 71035 +14
==========================================
- Hits 60015 55574 -4441
- Misses 11006 15461 +4455 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
LGTM but considering that the codecov fails... Can we add unit tests for L1920 and L1928 for Transaction.js. I think if we keep adding unit tests at some point it's going to stop crying that it doesn't reach the threshold.
It's something I tried to do in my PendingAirdropId PR. I tried to reach 100% codecov. It doesn't fail consistently for some reason but I think its because we are on the edge of the threshold and this is why it sometimes fails and sometimes passes.
…licKey method Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
ivaylogarnev-limechain
force-pushed
the
feat/2546-remove-all-signatures-return-type
branch
2 times, most recently
from
6ce791d
to
1fc4373
Compare
ivaylogarnev-limechain
force-pushed
the
feat/2546-remove-all-signatures-return-type
branch
from
e7e0546
to
5136a64
Compare
|
ivaylonikolov7
deleted the
feat/2546-remove-all-signatures-return-type
branch
b-l-u-e
pushed a commit
to b-l-u-e/hedera-sdk-js
that referenced
this pull request
Oct 13, 2024
…h#2559) * feat: Changed the return type of removeAllSignatures method of Transaction class and fixed unit and integration related tests Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * fix: Fixed some CI comments for typezation in collectSignaturesByPublicKey method Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * tests: Added tests for early return checks in _coolectSignaturesByPublicKey method Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> --------- Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech> Co-authored-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech> Signed-off-by: b-l-u-e <winnie.gitau282@gmail.com>
b-l-u-e
pushed a commit
to b-l-u-e/hedera-sdk-js
that referenced
this pull request
Oct 13, 2024
…h#2559) * feat: Changed the return type of removeAllSignatures method of Transaction class and fixed unit and integration related tests Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * fix: Fixed some CI comments for typezation in collectSignaturesByPublicKey method Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> * tests: Added tests for early return checks in _coolectSignaturesByPublicKey method Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> --------- Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech> Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech> Co-authored-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech> Signed-off-by: b-l-u-e <winnie.gitau282@gmail.com>
This was referenced Oct 14, 2024
Merged
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR changes the return type of the removeAllSignatures() method in the Transaction class. Additionally, it addresses and fixes the related unit and integration tests to ensure compatibility with this change
Fixes
#2546
Checklist