Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase test timeout globally #2566

Merged
merged 7 commits into from
Oct 14, 2024
Merged

fix: increase test timeout globally #2566

merged 7 commits into from
Oct 14, 2024

Conversation

ivaylonikolov7
Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 commented Oct 7, 2024

Description:
Changes tests execution by adding --timeout in every npx mocha command and adds timeout in browser environment too.

Fixes #

#2545

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech>
@ivaylonikolov7 ivaylonikolov7 changed the title fix: increase test timeout without repeating this.timeout(x) in every test fix: increase test timeout globally Oct 7, 2024
@ivaylonikolov7 ivaylonikolov7 added this to the v2.53.0 milestone Oct 7, 2024
@ivaylonikolov7 ivaylonikolov7 linked an issue Oct 7, 2024 that may be closed by this pull request
@ivaylonikolov7 ivaylonikolov7 self-assigned this Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (0e7b7f7) to head (5278161).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2566   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files         283      283           
  Lines       71038    71038           
=======================================
+ Hits        59986    59988    +2     
+ Misses      11052    11050    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech>
Signed-off-by: Ivaylo Nikolov <ivaylo.nikolov@limechain.tech>
@ivaylonikolov7 ivaylonikolov7 marked this pull request as ready for review October 8, 2024 19:00
@ivaylonikolov7 ivaylonikolov7 requested review from a team as code owners October 8, 2024 19:00
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @ivaylonikolov7

Copy link

sonarcloud bot commented Oct 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase test timeout
2 participants