Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Long term schedule consensus throttle #16487

Closed
wants to merge 97 commits into from

Conversation

JivkoKelchev
Copy link
Contributor

Description:

Related issue(s):

Fixes #16397

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

JivkoKelchev and others added 30 commits October 16, 2024 10:13
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
…transactions

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleWorkflow.java
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
refactor hapi tests

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
fix long term schedule throttle warning.

Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
…persistence' into 15055-POC-long-term-scheduled-transactions

# Conflicts:
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtility.java
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleCreateHandler.java
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleDeleteHandler.java
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleManager.java
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleSignHandler.java
#	hedera-node/hedera-schedule-service-impl/src/test/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtilityTest.java
#	hedera-node/hedera-schedule-service-impl/src/test/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleCreateHandlerTest.java
#	hedera-node/hedera-schedule-service-impl/src/test/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleManagerTest.java
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
…transactions

# Conflicts:
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/AbstractScheduleHandler.java
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/HandlerUtility.java
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleCreateHandler.java
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleDeleteHandler.java
#	hedera-node/hedera-schedule-service-impl/src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleSignHandler.java
…transactions

# Conflicts:
#	hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/handle/HandleWorkflowTest.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/queries/schedule/HapiGetScheduleInfo.java
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
@JivkoKelchev JivkoKelchev added this to the v0.57 milestone Nov 19, 2024
…into long-term-schedule-consensus-throttle

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/throttle/ThrottleAccumulator.java
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
@JivkoKelchev JivkoKelchev force-pushed the 15055-POC-long-term-scheduled-transactions branch from 448f73d to 1a34847 Compare November 20, 2024 10:13
JivkoKelchev and others added 9 commits November 20, 2024 12:27
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
…into long-term-schedule-consensus-throttle

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/throttle/ThrottleAccumulator.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/handle/HandleWorkflow.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip423/ScheduleLongTermExecutionTest.java
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 38.54167% with 118 lines in your changes missing coverage. Please review.

Project coverage is 63.39%. Comparing base (8569b20) to head (95f657e).
Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
...dera/node/app/workflows/handle/HandleWorkflow.java 29.57% 47 Missing and 3 partials ⚠️
...dera/node/app/throttle/ThrottleServiceManager.java 10.71% 25 Missing ⚠️
...orkflows/handle/throttle/DispatchUsageManager.java 24.13% 19 Missing and 3 partials ⚠️
...de/app/throttle/NetworkUtilizationManagerImpl.java 11.11% 8 Missing ⚠️
...ra/node/app/blocks/impl/KVStateChangeListener.java 0.00% 3 Missing ⚠️
...ode/app/workflows/handle/steps/UserTxnFactory.java 25.00% 2 Missing and 1 partial ⚠️
...p/workflows/handle/throttle/ThrottleException.java 0.00% 2 Missing ⚠️
...ce/schedule/impl/handlers/ScheduleSignHandler.java 60.00% 0 Missing and 2 partials ⚠️
.../hedera/node/app/throttle/ThrottleAccumulator.java 92.85% 0 Missing and 1 partial ⚠️
...hrottle/schemas/V0570CongestionThrottleSchema.java 90.90% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16487      +/-   ##
=============================================
- Coverage      63.40%   63.39%   -0.01%     
- Complexity     20212    20310      +98     
=============================================
  Files           2540     2545       +5     
  Lines          94287    94699     +412     
  Branches        9875     9891      +16     
=============================================
+ Hits           59783    60036     +253     
- Misses         30900    31046     +146     
- Partials        3604     3617      +13     
Files with missing lines Coverage Δ
...utils/throttles/GasLimitDeterministicThrottle.java 100.00% <100.00%> (ø)
...om/hedera/node/app/blocks/impl/BlockImplUtils.java 79.27% <100.00%> (+0.18%) ⬆️
...a/node/app/throttle/CongestionThrottleService.java 100.00% <100.00%> (ø)
...edera/node/app/throttle/ThrottleServiceModule.java 100.00% <100.00%> (ø)
.../schedule/impl/handlers/ScheduleCreateHandler.java 66.90% <100.00%> (+0.48%) ⬆️
.../hedera/node/app/throttle/ThrottleAccumulator.java 85.36% <92.85%> (-0.57%) ⬇️
...hrottle/schemas/V0570CongestionThrottleSchema.java 90.90% <90.90%> (ø)
...service/schedule/impl/handlers/HandlerUtility.java 95.03% <83.33%> (+0.03%) ⬆️
...p/workflows/handle/throttle/ThrottleException.java 75.00% <0.00%> (-25.00%) ⬇️
...ce/schedule/impl/handlers/ScheduleSignHandler.java 55.55% <60.00%> (-2.78%) ⬇️
... and 6 more

... and 103 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Nov 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.07% (target: -1.00%) 44.79%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8569b20) 97052 63212 65.13%
Head commit (95f657e) 97196 (+144) 63233 (+21) 65.06% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16487) 192 86 44.79%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

JivkoKelchev and others added 12 commits November 20, 2024 17:02
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech>
Base automatically changed from 15055-POC-long-term-scheduled-transactions to develop November 25, 2024 15:03
@JivkoKelchev
Copy link
Contributor Author

Throttles were added in this #16734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Dispatch to take the throttles being used at consensus
4 participants