-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Do stricter validation of X.509 gossip cert in DAB transactions #16666
Conversation
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @tinker-michaelj
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.56 #16666 +/- ##
===============================================
Coverage 58.35% 58.35%
- Complexity 20000 20002 +2
===============================================
Files 2738 2738
Lines 100489 100491 +2
Branches 10378 10378
===============================================
+ Hits 58643 58645 +2
Misses 38214 38214
Partials 3632 3632
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
aa0b34e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @tinker-michaelj
Description:
CertificateFactory.getInstance("X.509")
accepting the client's gossip X509 cert bytes, changeAddressBookValidator
to serialize the given bytes as a PEM X509 certificate; and validate an X509 cert can be parsed from the resulting PEM.