Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support override node admin keys #16781

Open
wants to merge 9 commits into
base: release/0.57
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Collaborator

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested review from a team as code owners November 25, 2024 19:51
@tinker-michaelj tinker-michaelj added this to the v0.57 milestone Nov 25, 2024
@tinker-michaelj tinker-michaelj self-assigned this Nov 25, 2024
Copy link

codacy-production bot commented Nov 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 76.14%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1b4339d) 97640 63764 65.31%
Head commit (70708f1) 97678 (+38) 63790 (+26) 65.31% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16781) 88 67 76.14%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.59%. Comparing base (1b4339d) to head (70708f1).

Files with missing lines Patch % Lines
...rc/main/java/com/hedera/node/app/ServicesMain.java 0.00% 14 Missing ⚠️
...ddressbook/impl/schemas/V053AddressBookSchema.java 84.00% 3 Missing and 1 partial ⚠️
.../node/app/workflows/handle/record/SystemSetup.java 93.02% 3 Missing ⚠️
.../platform/config/internal/PlatformConfigUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.57   #16781   +/-   ##
===============================================
  Coverage           63.59%   63.59%           
- Complexity          20399    20416   +17     
===============================================
  Files                2547     2547           
  Lines               94875    94913   +38     
  Branches             9913     9916    +3     
===============================================
+ Hits                60335    60361   +26     
- Misses              30922    30934   +12     
  Partials             3618     3618           
Files with missing lines Coverage Δ
...a/com/hedera/node/config/data/BootstrapConfig.java 100.00% <ø> (ø)
...om/hedera/node/config/data/NetworkAdminConfig.java 100.00% <ø> (ø)
...app/service/file/impl/schemas/V0490FileSchema.java 90.46% <100.00%> (-0.38%) ⬇️
.../platform/config/internal/PlatformConfigUtils.java 55.76% <0.00%> (ø)
.../node/app/workflows/handle/record/SystemSetup.java 91.46% <93.02%> (-0.03%) ⬇️
...ddressbook/impl/schemas/V053AddressBookSchema.java 94.44% <84.00%> (-2.11%) ⬇️
...rc/main/java/com/hedera/node/app/ServicesMain.java 27.55% <0.00%> (-2.11%) ⬇️

... and 17 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tinker-michaelj

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants