Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mirroring the changes from protobuf PR 453 #16786

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jsync-swirlds
Copy link
Member

  • Adding a few response codes.

 * Adding a few response codes.

Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
@jsync-swirlds jsync-swirlds self-assigned this Nov 26, 2024
@jsync-swirlds jsync-swirlds added the Block Node Issues related to the Block Node. label Nov 26, 2024
@jsync-swirlds jsync-swirlds changed the title Mirroring the changes from protobuf PR 453 chore: Mirroring the changes from protobuf PR 453 Nov 26, 2024
@jsync-swirlds jsync-swirlds added this to the v0.57 milestone Nov 26, 2024
@jsync-swirlds jsync-swirlds added Backlog Work that needs to be done sometime in the future. No milestone assigned or not yet available. and removed Backlog Work that needs to be done sometime in the future. No milestone assigned or not yet available. labels Nov 26, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (935fdb1) 97511 63616 65.24%
Head commit (8276b9e) 97511 (+0) 63623 (+7) 65.25% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16786) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.54%. Comparing base (935fdb1) to head (8276b9e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16786      +/-   ##
=============================================
+ Coverage      63.53%   63.54%   +0.01%     
- Complexity     20370    20377       +7     
=============================================
  Files           2537     2537              
  Lines          94746    94746              
  Branches        9902     9902              
=============================================
+ Hits           60198    60208      +10     
+ Misses         30941    30934       -7     
+ Partials        3607     3604       -3     

see 10 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues related to the Block Node.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant