Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry Pick: State validation fails for round 191161423 on LSE #16796

Open
wants to merge 1 commit into
base: release/0.57
Choose a base branch
from

Conversation

thenswan
Copy link
Contributor

Cherry-pick of PR #16757

@thenswan thenswan requested review from a team as code owners November 26, 2024 08:35
@thenswan thenswan force-pushed the 16758-backport-the-fix-for-16657-to-057 branch from cb5b10d to 509ee9f Compare November 26, 2024 08:42
@thenswan thenswan self-assigned this Nov 26, 2024
@thenswan thenswan added this to the v0.57 milestone Nov 26, 2024
Fixes: #16657
Reviewed-by: Ivan Malygin <ivan@swirldslabs.com>, Oleg Mazurov <oleg.mazurov@swirldslabs.com>
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
Signed-off-by: artemananiev <33361937+artemananiev@users.noreply.github.com>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
@thenswan thenswan force-pushed the 16758-backport-the-fix-for-16657-to-057 branch from 509ee9f to 0441bb2 Compare November 26, 2024 08:45
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.58%. Comparing base (a311dd9) to head (0441bb2).

Files with missing lines Patch % Lines
...wirlds/virtualmap/internal/hash/VirtualHasher.java 66.66% 1 Missing and 1 partial ⚠️
...rtualmap/internal/merkle/AbstractHashListener.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.57   #16796      +/-   ##
==================================================
- Coverage           63.59%   63.58%   -0.01%     
+ Complexity          20398    20393       -5     
==================================================
  Files                2547     2547              
  Lines               94873    94872       -1     
  Branches             9912     9912              
==================================================
- Hits                60333    60324       -9     
- Misses              30921    30927       +6     
- Partials             3619     3621       +2     
Files with missing lines Coverage Δ
...almap/internal/reconnect/ReconnectNodeRemover.java 93.54% <100.00%> (+9.17%) ⬆️
...rtualmap/internal/merkle/AbstractHashListener.java 84.37% <66.66%> (+1.29%) ⬆️
...wirlds/virtualmap/internal/hash/VirtualHasher.java 86.59% <66.66%> (-0.45%) ⬇️

... and 12 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 90.91%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a311dd9) 97638 63763 65.31%
Head commit (0441bb2) 97637 (-1) 63756 (-7) 65.30% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16796) 11 10 90.91%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@thenswan thenswan linked an issue Nov 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport the fix for 16657 to 0.57
3 participants