Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Schedule Create POSITIVE tests from test plan #16797

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Nov 26, 2024

Description:
Covering ScheduleCreate - Positive Scenarios from the test plan

Also refactor ScheduleLongTermSign and ScheduleLongTermExecute to use hapiTest() instead of given()/when()/then()

Related issue(s):
#16737

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: ibankov <ivan.bankov@limechain.tech>
@ibankov ibankov added this to the v0.57 milestone Nov 26, 2024
@ibankov ibankov self-assigned this Nov 26, 2024
Copy link

codacy-production bot commented Nov 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0759d3d) 97519 63701 65.32%
Head commit (305b848) 97519 (+0) 63743 (+42) 65.36% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16797) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.67%. Comparing base (0759d3d) to head (305b848).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16797      +/-   ##
=============================================
+ Coverage      63.62%   63.67%   +0.05%     
- Complexity     20401    20425      +24     
=============================================
  Files           2537     2537              
  Lines          94754    94754              
  Branches        9904     9904              
=============================================
+ Hits           60285    60338      +53     
+ Misses         30863    30821      -42     
+ Partials        3606     3595      -11     

see 11 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
@ibankov ibankov marked this pull request as ready for review November 27, 2024 14:52
@ibankov ibankov requested review from a team as code owners November 27, 2024 14:52
# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip423/ScheduleLongTermExecutionTest.java
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Signed-off-by: ibankov <ivan.bankov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant