-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Protobufs for Tss Startup #16822
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple thoughts regarding the proto definitions and storing transaction body messages in state.
Also, several general style guidelines items.
/** | ||
* A TSS Encryption Key Transaction Body value. | ||
*/ | ||
com.hedera.hapi.services.auxiliary.tss.TssEncryptionKeyTransactionBody tss_encryption_key_value = 20; | ||
|
||
/** | ||
* A TSS Encryption Key Transaction Body value. | ||
*/ | ||
com.hedera.hapi.services.auxiliary.tss.TssMessageTransactionBody tss_message_value = 21; | ||
|
||
/** | ||
* A TSS Encryption Key Transaction Body value. | ||
*/ | ||
com.hedera.hapi.services.auxiliary.tss.TssVoteTransactionBody tss_vote_value = 22; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really should not be storing transaction bodies in state; it sets a bad pattern.
Ideally we would use an internal message for these, or base type (if there is only one field, as is the case for the encryption key).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the internal transaction bodies, submitted by Tss Service, not the user submitted transaction bodies. You could refer to the TssLedgerID proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read the proposal, repeatedly.
This usage is still a divergence from how everything else is stored in state (we don't store full transaction bodies for anything else) and is concerning in the block stream (where we work so hard to avoid any transaction data in other parts of the stream).
It just seems we're taking a shortcut here to avoid defining the state messages. If the team believes this is the best way to implement, then that's what it will be, I am just suggesting we reconsider if this really is good design.
com.hedera.hapi.services.auxiliary.tss.TssEncryptionKeyTransactionBody tss_encryption_key_value = 20; | ||
|
||
/** | ||
* A TSS Encryption Key Transaction Body value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to include additional detail and requirements if we truly do need to store full transaction body messages in state, as it's a major divergence from everything else, and is highly likely to be confusing to anyone reading this next year.
hapi/hedera-protobufs/services/auxiliary/tss/tss_encryption_key.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com>
Fixes #16823
Related to #14751
Protobufs for TssEncryptionKeys and TssStatus