Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 16750 Fixed serialization for ISSTestingToolState #16826

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

imalygin
Copy link
Member

This PR fixes the following tests:

ISS-catastrophic-1k-5
ISS-recoverable-1k-5m

There were two causes of the failure:

  1. Absent state serialization
  2. NPE in ISSTestingToolState#findLargestPartition.

Both issues are resolved.

Fixes #16750

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Also fixed an NPE

Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
@imalygin imalygin added this to the v0.57 milestone Nov 27, 2024
@imalygin imalygin self-assigned this Nov 27, 2024
@imalygin imalygin requested a review from a team as a code owner November 27, 2024 20:05
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (32089ae) 97522 63704 65.32%
Head commit (807f4e6) 97551 (+29) 63704 (+0) 65.30% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16826) 30 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 63.60%. Comparing base (32089ae) to head (807f4e6).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...java/com/swirlds/demo/iss/ISSTestingToolState.java 0.00% 30 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16826      +/-   ##
=============================================
- Coverage      63.62%   63.60%   -0.02%     
  Complexity     20401    20401              
=============================================
  Files           2537     2537              
  Lines          94757    94786      +29     
  Branches        9904     9907       +3     
=============================================
  Hits           60288    60288              
- Misses         30863    30892      +29     
  Partials        3606     3606              
Files with missing lines Coverage Δ
...java/com/swirlds/demo/iss/ISSTestingToolState.java 0.00% <0.00%> (ø)

Impacted file tree graph

@lpetrovic05 lpetrovic05 merged commit 539f059 into develop Nov 28, 2024
61 of 63 checks passed
@lpetrovic05 lpetrovic05 deleted the 16750-jtr-no-iss-detected branch November 28, 2024 13:54
@imalygin imalygin added Platform Tickets pertaining to the platform and removed Platform Tickets pertaining to the platform labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JTR Failure: ISS-catastrophic-1k-5m and ISS-recoverable-1k-5m
3 participants