Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: improve error message when using incorrect version of java #16827

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ElijahLynn
Copy link
Contributor

@ElijahLynn ElijahLynn commented Nov 28, 2024

From a n00b perspective the current gradle messaging was confusing, I propose this change to make it more clear that we MUST make a change.

current:

Gradle runs with Java $currentJavaVersion. This project works best running with Java $expectedJavaVersion. 

proposed:

Gradle is running with $currentJavaVersion. This project requires Java $expectedJavaVersion. 
     From commandline: change JAVA_HOME and/or PATH to point at Java $expectedJavaVersion installation.
     From IntelliJ: change 'Gradle JVM' in 'Gradle Settings' to point at Java $expectedJavaVersion installation.

@ElijahLynn ElijahLynn requested review from a team as code owners November 28, 2024 01:03
@ElijahLynn ElijahLynn changed the title gradle: improve error text w/incorrect version of java gradle: improve error message when using incorrect version of java Nov 28, 2024
Copy link

codacy-production bot commented Nov 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (539f059) 97548 63701 65.30%
Head commit (0bc7b68) 97548 (+0) 63703 (+2) 65.30% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16827) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.60%. Comparing base (539f059) to head (0bc7b68).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16827   +/-   ##
==========================================
  Coverage      63.60%   63.60%           
- Complexity     20401    20404    +3     
==========================================
  Files           2537     2537           
  Lines          94783    94783           
  Branches        9907     9907           
==========================================
+ Hits           60285    60286    +1     
+ Misses         30892    30890    -2     
- Partials        3606     3607    +1     

see 6 files with indirect coverage changes

Impacted file tree graph

Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants