-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allowed ERC registry indexing tool to target localnet #1071
feat: allowed ERC registry indexing tool to target localnet #1071
Conversation
Test Results 16 files ± 0 83 suites +1 12m 23s ⏱️ + 2m 8s Results for commit f0cc24d. ± Comparison against base commit af82723. This pull request removes 1 and adds 18 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, but isn't this something that should be provided by local node? the forwarding to web3?
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
83c9862
to
f0cc24d
Compare
Yeah ha actually it's a good point. I think it's doable okay will create a ticket on local-node repo. Thanks for pointing it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg
Description:
Contract call APIs interact with the Mirror Node Web3Module, but the local network does not automatically forward these requests. As a result, the indexing tool must manually redirect contract call requests to the Web3Module endpoint.
To address this, this PR introduces the
MIRROR_NODE_URL_WEB3
configuration. This addition enables the ERC registry indexing tool to seamlessly execute contract call APIs against the Web3Module, ensuring effective targeting of the local network.Related issue(s):
Fixes #1070
Notes for reviewer:
This PR builds upon the changes introduced in PR #1064. As a result, many updates from PR #1064 are reflected here.
It is recommended to review PR #1064 before proceeding with this one.
Checklist