Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowed ERC registry indexing tool to target localnet #1071

Conversation

quiet-node
Copy link
Member

Description:
Contract call APIs interact with the Mirror Node Web3Module, but the local network does not automatically forward these requests. As a result, the indexing tool must manually redirect contract call requests to the Web3Module endpoint.

To address this, this PR introduces the MIRROR_NODE_URL_WEB3 configuration. This addition enables the ERC registry indexing tool to seamlessly execute contract call APIs against the Web3Module, ensuring effective targeting of the local network.

Related issue(s):

Fixes #1070

Notes for reviewer:
This PR builds upon the changes introduced in PR #1064. As a result, many updates from PR #1064 are reflected here.

It is recommended to review PR #1064 before proceeding with this one.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Dec 10, 2024
@quiet-node quiet-node added this to the 0.11.0 milestone Dec 10, 2024
@quiet-node quiet-node self-assigned this Dec 10, 2024
@quiet-node quiet-node requested a review from a team as a code owner December 10, 2024 03:28
@quiet-node quiet-node linked an issue Dec 10, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 10, 2024

Test Results

 16 files  ± 0   83 suites  +1   12m 23s ⏱️ + 2m 8s
294 tests +17  288 ✅ +19  6 💤 ±0  0 ❌  - 2 
303 runs  +15  296 ✅ +17  7 💤 ±0  0 ❌  - 2 

Results for commit f0cc24d. ± Comparison against base commit af82723.

This pull request removes 1 and adds 18 tests. Note that renamed tests count towards both.
"before each" hook for "should be able to update fixed fee in HBARs for NFT" ‑ TokenManagmentContract Test Suite Update fees "before each" hook for "should be able to update fixed fee in HBARs for NFT"
should be able to update fixed HTS fee and royalty fee in NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed HTS fee and royalty fee in NFT
should be able to update fixed HTS fee for NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed HTS fee for NFT
should be able to update fixed fee in HBARs for NFT ‑ TokenManagmentContract Test Suite Update fees should be able to update fixed fee in HBARs for NFT
should fail for updateFungibleTokenCustomFees when token is not associated to fee collector ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail for updateFungibleTokenCustomFees when token is not associated to fee collector
should fail for updateNonFungibleTokenCustomFees when token is not associated to fee collector ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail for updateNonFungibleTokenCustomFees when token is not associated to fee collector
should fail when fee has negative values for non fungible token ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when fee has negative values for non fungible token
should fail when fee has negative values ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when fee has negative values
should fail when fractional fee has denominator zero ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when fractional fee has denominator zero
should fail when the provided fee collector is invalid for NFT ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when the provided fee collector is invalid for NFT
should fail when the provided fee collector is invalid ‑ TokenManagmentContract Test Suite Update fees Update fees negative cases should fail when the provided fee collector is invalid
…

♻️ This comment has been updated with latest results.

acuarica
acuarica previously approved these changes Dec 10, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, but isn't this something that should be provided by local node? the forwarding to web3?

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 1070-erc-registry-phase-2-allow-the-tool-to-run-against-localnet branch from 83c9862 to f0cc24d Compare December 10, 2024 20:37
@quiet-node
Copy link
Member Author

quiet-node commented Dec 10, 2024

lg, but isn't this something that should be provided by local node? the forwarding to web3?

Yeah ha actually it's a good point. I think it's doable okay will create a ticket on local-node repo. Thanks for pointing it out!

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@quiet-node quiet-node merged commit b29a7dc into main Dec 10, 2024
30 checks passed
@quiet-node quiet-node deleted the 1070-erc-registry-phase-2-allow-the-tool-to-run-against-localnet branch December 10, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ERC Registry] Phase 2: Allow the tool to run against localnet
2 participants