1342 threshold nicknames #1544
Open
1342 threshold nicknames #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheng-Long
requested review from
SvetBorislavov,
yiliev0 and
a team
as code owners
Sheng-Long
force-pushed
the
1342-threshold-nicknames
branch
2 times, most recently
from
91e9824 to
629b960
Compare
jsync-swirlds
requested review from
jbair06
and removed request for
jsync-swirlds
Sheng-Long
force-pushed
the
1342-threshold-nicknames
branch
from
629b960 to
0e7724e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 159 159
Lines 5950 5953 +3
Branches 1092 1092
=======================================
+ Hits 5895 5898 +3
+ Misses 55 52 -3
- Partials 0 3 +3
... and 3 files with indirect coverage changes |
Sheng-Long
force-pushed
the
1342-threshold-nicknames
branch
from
0e7724e to
21be27f
Compare
Signed-off-by: Tim Schmidt <tim@launchbadge.com>
Signed-off-by: Tim Schmidt <tim@launchbadge.com>
Sheng-Long
force-pushed
the
1342-threshold-nicknames
branch
from
21be27f to
35e9a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes threshold nickname bugs
Related issue(s):
Fixes #1342, #1542
Notes for reviewer:
Checklist