Add support for multiple sessions #135
Conversation
This commit introduces support for multiple sessions via Wallet Connect client, enabling developers to manage various accountIds simultaneously. Redundant functions have been removed for cleaner code. Signed-off-by: Fran Fernandez <fran@kabila.app>
franfernandez20
requested review from
justynspooner,
teacoat,
bugbytesinc and
valeraOlexienko
| } | ||
| } | ||
|
|
||
| private async checkPersistedState() { |
There was a problem hiding this comment.
My review doesn't account for removing checkPersistedState or pingWithRetry. I don't think I'm qualified to review if these can be removed :)
|
|
||
| if (existingSessions.length) { | ||
| await this.onSessionConnected(existingSessions.pop()!) | ||
| const existingSessions = this.walletConnectClient.session.getAll() |
There was a problem hiding this comment.
Could you please explain a bit why the logic for checking really alive sessions has been removed and simplified to this one?
There was a problem hiding this comment.
This function was designed to remove sessions when the corresponding wallet in the communication fails to respond. Non-responsiveness can occur if the wallet is closed or temporarily inaccessible; however, it is crucial that the session remains valid during such intervals. The getAll method from WalletConnect core is tasked with reinstating any session that should remain active, ensuring continuity and stability in the communication process.
Signed-off-by: Fran Fernandez <fran@kabila.app>
|
Nice work! |
This commit introduces support for multiple sessions via Wallet Connect client, enabling developers to manage various accountIds simultaneously.
Redundant functions have been removed for cleaner code.
Notes for reviewer:
This pull request is part of PR#76, which will be permanently deleted once all topics are split.
Checklist