Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransactionRecord Query #251

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

MiguelLZPF
Copy link
Contributor

Description:

Add TransactionRecordQuery type to _parseQueryResponse

Related issue(s):

Fixes #229

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Miguel_LZPF <miguel.carpena@io.builders>
@MiguelLZPF MiguelLZPF marked this pull request as ready for review August 26, 2024 09:01
@MiguelLZPF MiguelLZPF requested review from a team as code owners August 26, 2024 09:01
@MiguelLZPF MiguelLZPF requested a review from mgarbs August 26, 2024 09:01
Copy link
Contributor

@tmctl tmctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution!

@itsbrandondev itsbrandondev added Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone. labels Aug 26, 2024
@tmctl
Copy link
Contributor

tmctl commented Aug 26, 2024

verbal 2nd approval on working group call today

@tmctl tmctl merged commit 473626d into hashgraph:main Aug 26, 2024
9 checks passed
@MiguelLZPF MiguelLZPF deleted the fix/add-tx-record-query branch August 27, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with getRecord Query Failing When Using Hedera Wallet Connect for Stablecoin Creation
3 participants