Feat/iframe extension connect #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teacoat
reviewed
Apr 2, 2024
zanctor
reviewed
Apr 4, 2024
franfernandez20
force-pushed
the
feat/iframe-extension-connect
branch
from
da01a5a
to
a89cee0
Compare
zanctor
approved these changes
Jun 11, 2024
franfernandez20
force-pushed
the
feat/iframe-extension-connect
branch
from
8136a27
to
3434c8c
Compare
This commit introduces new messages that allow the web dApp to establish a session by sending messages to the parent extension. In case an iframe is detected but no connection is established, the dApp will send a message to the parent extension to initiate a connection. Signed-off-by: Fran Fernandez <fran@kabila.app>
Signed-off-by: Fran Fernandez <fran@kabila.app>
franfernandez20
force-pushed
the
feat/iframe-extension-connect
branch
from
3434c8c
to
e6e3a06
Compare
Signed-off-by: Fran Fernandez <fran@kabila.app>
|
I have added support for this feature in the demo. Attached is a video demonstrating its behaviour within an iframe inside the extension. iframe-extension.mov |
justynspooner
approved these changes
Jun 26, 2024
| @@ -128,8 +130,9 @@ export class DAppConnector { | |||
| }) | |||
| const existingSessions = this.walletConnectClient.session.getAll() | |||
|
|
|||
| if (existingSessions) | |||
| if (existingSessions.length > 0) | |||
Co-authored-by: Justyn Spooner <justynjj@gmail.com> Signed-off-by: Fran Fernández <franfernandez20@gmail.com>
Co-authored-by: Justyn Spooner <justynjj@gmail.com> Signed-off-by: Fran Fernández <franfernandez20@gmail.com>
Co-authored-by: Justyn Spooner <justynjj@gmail.com> Signed-off-by: Fran Fernández <franfernandez20@gmail.com>
Co-authored-by: Justyn Spooner <justynjj@gmail.com> Signed-off-by: Fran Fernández <franfernandez20@gmail.com>
Thank you for the corrections 🙏 . All of them have been applied. |
|
Looking forward to this commit being approved! |
teacoat
approved these changes
Jul 1, 2024
tmctl
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit introduces new messages that allow the web dApp to establish a session by sending messages to the parent extension.
Checklist