Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance node add to work with staking and dynamic address book #469

Merged
merged 61 commits into from
Aug 14, 2024
Merged

feat: enhance node add to work with staking and dynamic address book #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
ef778f6
save
JeffreyDallas Jun 26, 2024
50dc4fa
build zip package
JeffreyDallas Jul 1, 2024
47e882f
stash
JeffreyDallas Jul 1, 2024
7c0dffd
save
JeffreyDallas Jul 10, 2024
0558513
save
JeffreyDallas Jun 26, 2024
e03f295
build zip package
JeffreyDallas Jul 1, 2024
42dbe75
NodeCreateTransaction
jeromy-cannon Jul 18, 2024
342075a
// scheduleNetworkUpdate is set to false, because the ports 502…
jeromy-cannon Jul 18, 2024
64f7981
increased default stake amount
jeromy-cannon Jul 18, 2024
1c7f216
get the treasury key, it might be in k8s secret, else genesis key
jeromy-cannon Jul 18, 2024
407ffa1
todo's after conversations in Slack
jeromy-cannon Jul 18, 2024
933d741
Merge branch '00381-D-staking-nodes' of https://github.com/hashgraph/…
JeffreyDallas Jul 22, 2024
da231bb
update
JeffreyDallas Jul 24, 2024
febbaf0
feat: implement solo node add with dynamic address-book support
leninmehedy Jul 30, 2024
3cab753
merged from main
jeromy-cannon Jul 30, 2024
2df92a9
lint fixes
jeromy-cannon Jul 30, 2024
e5522fa
bumped version
jeromy-cannon Jul 30, 2024
b417e9b
FREEZE_ADMIN_ACCOUNT
jeromy-cannon Jul 30, 2024
b46d459
saving progress, network doesn't come back up, yet
jeromy-cannon Jul 30, 2024
637d7a0
latest
jeromy-cannon Jul 31, 2024
e1057be
latest after talking with Iris and Lev
jeromy-cannon Jul 31, 2024
d8a391e
upgrade @hasgraph/sdk to 2.49.2 to pick up bug fix for connection dro…
jeromy-cannon Aug 6, 2024
6ce82c2
application.properties: set stake weight calculations to once per minute
jeromy-cannon Aug 7, 2024
e37cb3a
log4j2.xml: trigger new file for swirlds.log and hgcaa.log on startup
jeromy-cannon Aug 7, 2024
21f4c9f
current version updates
jeromy-cannon Aug 8, 2024
b7ac9e3
working version
jeromy-cannon Aug 8, 2024
d481fd5
add todo
jeromy-cannon Aug 8, 2024
229c171
revert
jeromy-cannon Aug 9, 2024
39c9792
updates for PR reviews
jeromy-cannon Aug 9, 2024
d8f8072
cleanup
jeromy-cannon Aug 9, 2024
36af0e1
handle account info query returning key instead of array of keys
jeromy-cannon Aug 9, 2024
916dff8
Merge branch 'main' into 00381-node-add
jeromy-cannon Aug 12, 2024
d8333a4
sleep for 30 seconds after starting nodes so that logs can roll over
jeromy-cannon Aug 12, 2024
79bc289
removed account balance info, as it is now staked to node id instead …
jeromy-cannon Aug 12, 2024
325ffb8
removed console.log
jeromy-cannon Aug 12, 2024
5d1386c
remove unused import
jeromy-cannon Aug 12, 2024
d3b2160
cleanup use of ctx.config
jeromy-cannon Aug 12, 2024
544aa2d
cleanup use of ctx.config
jeromy-cannon Aug 12, 2024
ed43861
cleanup use of ctx.config
jeromy-cannon Aug 12, 2024
f8fff76
revert location of methods to prevent merge conflict issues with othe…
jeromy-cannon Aug 12, 2024
5057474
removed commented out code
jeromy-cannon Aug 12, 2024
05d2b33
captured issue and removed TODO
jeromy-cannon Aug 12, 2024
afde04a
updated builds for node-add
jeromy-cannon Aug 12, 2024
9a3cfc8
fixed lint errors
jeromy-cannon Aug 12, 2024
31b67f1
fixed lint errors
jeromy-cannon Aug 12, 2024
cdf3212
fixed lint errors
jeromy-cannon Aug 12, 2024
22bcc5b
fixed test case problem in node-add
jeromy-cannon Aug 13, 2024
d106eb9
making tests more resilient
jeromy-cannon Aug 13, 2024
e9105a7
making tests more resilient
jeromy-cannon Aug 13, 2024
eb4e598
beta version v2.50.0-beta.3 with DAB functionality
jeromy-cannon Aug 13, 2024
8f17073
fix static code analysis issues
jeromy-cannon Aug 13, 2024
c954e8c
Merge branch 'main' into 00381-node-add
jeromy-cannon Aug 13, 2024
999ebf4
all of the sudden helm is not being found in the pipeline?
jeromy-cannon Aug 13, 2024
c8a44bb
cleanup
jeromy-cannon Aug 13, 2024
6c8ca30
Merge branch 'main' into 00381-node-add
jeromy-cannon Aug 13, 2024
3066b5a
cleanup
jeromy-cannon Aug 13, 2024
19b54ca
fixed mirror node test case
jeromy-cannon Aug 13, 2024
c8c9aac
fixed k8 and afterAll in node e2e
jeromy-cannon Aug 14, 2024
bb0605b
fixed k8 e2e test
jeromy-cannon Aug 14, 2024
b7aea1a
match proto version to what sdk is using
jeromy-cannon Aug 14, 2024
fd366cd
fix coverage analysis bug
jeromy-cannon Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 31 additions & 16 deletions .github/workflows/flow-build-application.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,31 +91,31 @@ jobs:
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-mirror-node-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-mirror-node-coverage-report }}

e2e-node-pem-stop-add-tests:
e2e-node-pem-stop-tests:
name: E2E Tests
if: ${{ github.event_name == 'push' || github.event.inputs.enable-e2e-tests == 'true' }}
uses: ./.github/workflows/zxc-e2e-test.yaml
needs:
- env-vars
- code-style
with:
custom-job-label: Node PEM Stop Add
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-pem-stop-add-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-coverage-report }}
custom-job-label: Node PEM Stop
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-pem-stop-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-pem-stop-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-pem-stop-coverage-report }}

e2e-node-pfx-kill-add-tests:
e2e-node-pfx-kill-tests:
name: E2E Tests
if: ${{ github.event_name == 'push' || github.event.inputs.enable-e2e-tests == 'true' }}
uses: ./.github/workflows/zxc-e2e-test.yaml
needs:
- env-vars
- code-style
with:
custom-job-label: Node PFX Kill Add
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-coverage-report }}
custom-job-label: Node PFX Kill
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-pfx-kill-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-coverage-report }}

e2e-node-local-build-tests:
name: E2E Tests
Expand All @@ -129,6 +129,18 @@ jobs:
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-local-build-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-local-build-coverage-report }}

e2e-node-add-tests:
name: E2E Tests
uses: ./.github/workflows/zxc-e2e-test.yaml
needs:
- env-vars
- code-style
with:
custom-job-label: Node Add
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-add-coverage-report }}

e2e-relay-tests:
name: E2E Tests
if: ${{ github.event_name == 'push' || github.event.inputs.enable-e2e-tests == 'true' }}
Expand All @@ -151,9 +163,10 @@ jobs:
- unit-tests
- e2e-tests
- e2e-mirror-node-tests
- e2e-node-pem-stop-add-tests
- e2e-node-pfx-kill-add-tests
- e2e-node-pem-stop-tests
- e2e-node-pfx-kill-tests
- e2e-node-local-build-tests
- e2e-node-add-tests
- e2e-relay-tests
if: ${{ (github.event_name == 'push' || github.event.inputs.enable-unit-tests == 'true' || github.event.inputs.enable-e2e-tests == 'true') && !failure() && !cancelled() }}
with:
Expand All @@ -164,15 +177,17 @@ jobs:
enable-e2e-coverage-report: ${{ github.event_name == 'push' || github.event.inputs.enable-e2e-tests == 'true' }}
e2e-test-subdir: ${{ needs.env-vars.outputs.e2e-test-subdir }}
e2e-mirror-node-test-subdir: ${{ needs.env-vars.outputs.e2e-mirror-node-test-subdir }}
e2e-node-pem-stop-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-test-subdir }}
e2e-node-pfx-kill-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-test-subdir }}
e2e-node-pem-stop-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pem-stop-test-subdir }}
e2e-node-pfx-kill-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-test-subdir }}
e2e-node-local-build-test-subdir: ${{ needs.env-vars.outputs.e2e-node-local-build-test-subdir }}
e2e-node-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}
e2e-relay-test-subdir: ${{ needs.env-vars.outputs.e2e-relay-test-subdir }}
e2e-coverage-report: ${{ needs.env-vars.outputs.e2e-coverage-report }}
e2e-mirror-node-coverage-report: ${{ needs.env-vars.outputs.e2e-mirror-node-coverage-report }}
e2e-node-pem-stop-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-coverage-report }}
e2e-node-pfx-kill-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-coverage-report }}
e2e-node-pem-stop-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pem-stop-coverage-report }}
e2e-node-pfx-kill-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-coverage-report }}
e2e-node-local-build-coverage-report: ${{ needs.env-vars.outputs.e2e-node-local-build-coverage-report }}
e2e-node-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-add-coverage-report }}
e2e-relay-coverage-report: ${{ needs.env-vars.outputs.e2e-relay-coverage-report }}
secrets:
snyk-token: ${{ secrets.SNYK_TOKEN }}
Expand Down
79 changes: 51 additions & 28 deletions .github/workflows/flow-pull-request-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,29 +78,29 @@ jobs:
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-mirror-node-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-mirror-node-coverage-report }}

e2e-node-pem-stop-add-tests:
e2e-node-pem-stop-tests:
name: E2E Tests
uses: ./.github/workflows/zxc-e2e-test.yaml
needs:
- env-vars
- code-style
with:
custom-job-label: Node PEM Stop Add
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-pem-stop-add-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-coverage-report }}
custom-job-label: Node PEM Stop
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-pem-stop-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-pem-stop-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-pem-stop-coverage-report }}

e2e-node-pfx-kill-add-tests:
e2e-node-pfx-kill-tests:
name: E2E Tests
uses: ./.github/workflows/zxc-e2e-test.yaml
needs:
- env-vars
- code-style
with:
custom-job-label: Node PFX Kill Add
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-coverage-report }}
custom-job-label: Node PFX Kill
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-pfx-kill-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-coverage-report }}

e2e-node-local-build-tests:
name: E2E Tests
Expand All @@ -114,6 +114,18 @@ jobs:
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-local-build-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-local-build-coverage-report }}

e2e-node-add-tests:
name: E2E Tests
uses: ./.github/workflows/zxc-e2e-test.yaml
needs:
- env-vars
- code-style
with:
custom-job-label: Node Add
npm-test-script: test-${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}
coverage-subdirectory: ${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}
coverage-report-name: ${{ needs.env-vars.outputs.e2e-node-add-coverage-report }}

e2e-relay-tests:
name: E2E Tests
if: ${{ !cancelled() && always() }}
Expand All @@ -136,9 +148,10 @@ jobs:
- unit-tests
- e2e-tests
- e2e-mirror-node-tests
- e2e-node-pem-stop-add-tests
- e2e-node-pfx-kill-add-tests
- e2e-node-pem-stop-tests
- e2e-node-pfx-kill-tests
- e2e-node-local-build-tests
- e2e-node-add-tests
- e2e-relay-tests
if: ${{ github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name }}
with:
Expand All @@ -147,15 +160,17 @@ jobs:
enable-e2e-coverage-report: true
e2e-test-subdir: ${{ needs.env-vars.outputs.e2e-test-subdir }}
e2e-mirror-node-test-subdir: ${{ needs.env-vars.outputs.e2e-mirror-node-test-subdir }}
e2e-node-pem-stop-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-test-subdir }}
e2e-node-pfx-kill-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-test-subdir }}
e2e-node-pem-stop-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pem-stop-test-subdir }}
e2e-node-pfx-kill-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-test-subdir }}
e2e-node-local-build-test-subdir: ${{ needs.env-vars.outputs.e2e-node-local-build-test-subdir }}
e2e-node-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}
e2e-relay-test-subdir: ${{ needs.env-vars.outputs.e2e-relay-test-subdir }}
e2e-coverage-report: ${{ needs.env-vars.outputs.e2e-coverage-report }}
e2e-mirror-node-coverage-report: ${{ needs.env-vars.outputs.e2e-mirror-node-coverage-report }}
e2e-node-pem-stop-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-coverage-report }}
e2e-node-pfx-kill-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-coverage-report }}
e2e-node-pem-stop-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pem-stop-coverage-report }}
e2e-node-pfx-kill-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-coverage-report }}
e2e-node-local-build-coverage-report: ${{ needs.env-vars.outputs.e2e-node-local-build-coverage-report }}
e2e-node-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-add-coverage-report }}
e2e-relay-coverage-report: ${{ needs.env-vars.outputs.e2e-relay-coverage-report }}
secrets:
codecov-token: ${{ secrets.CODECOV_TOKEN }}
Expand All @@ -168,9 +183,10 @@ jobs:
- unit-tests
- e2e-tests
- e2e-mirror-node-tests
- e2e-node-pem-stop-add-tests
- e2e-node-pfx-kill-add-tests
- e2e-node-pem-stop-tests
- e2e-node-pfx-kill-tests
- e2e-node-local-build-tests
- e2e-node-add-tests
- e2e-relay-tests
if: ${{ github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name }}
with:
Expand All @@ -179,15 +195,17 @@ jobs:
enable-e2e-coverage-report: true
e2e-test-subdir: ${{ needs.env-vars.outputs.e2e-test-subdir }}
e2e-mirror-node-test-subdir: ${{ needs.env-vars.outputs.e2e-mirror-node-test-subdir }}
e2e-node-pem-stop-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-test-subdir }}
e2e-node-pfx-kill-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-test-subdir }}
e2e-node-pem-stop-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pem-stop-test-subdir }}
e2e-node-pfx-kill-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-test-subdir }}
e2e-node-local-build-test-subdir: ${{ needs.env-vars.outputs.e2e-node-local-build-test-subdir }}
e2e-node-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}
e2e-relay-test-subdir: ${{ needs.env-vars.outputs.e2e-relay-test-subdir }}
e2e-coverage-report: ${{ needs.env-vars.outputs.e2e-coverage-report }}
e2e-mirror-node-coverage-report: ${{ needs.env-vars.outputs.e2e-mirror-node-coverage-report }}
e2e-node-pem-stop-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-coverage-report }}
e2e-node-pfx-kill-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-coverage-report }}
e2e-node-pem-stop-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pem-stop-coverage-report }}
e2e-node-pfx-kill-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-coverage-report }}
e2e-node-local-build-coverage-report: ${{ needs.env-vars.outputs.e2e-node-local-build-coverage-report }}
e2e-node-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-add-coverage-report }}
e2e-relay-coverage-report: ${{ needs.env-vars.outputs.e2e-relay-coverage-report }}
secrets:
codacy-project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
Expand All @@ -200,23 +218,28 @@ jobs:
# - unit-tests
# - e2e-tests
# - e2e-mirror-node-tests
# - e2e-node-pem-stop-add-tests
# - e2e-node-pfx-kill-add-tests
# - e2e-node-pem-stop-tests
# - e2e-node-pfx-kill-tests
# - e2e-node-local-build-tests
# - e2e-node-add-tests
# - e2e-relay-tests
# if: ${{ github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name && github.actor != 'dependabot[bot]' }}
# with:
# custom-job-label: Standard
# enable-snyk-scan: true
# e2e-test-subdir: ${{ needs.env-vars.outputs.e2e-test-subdir }}
# e2e-mirror-node-test-subdir: ${{ needs.env-vars.outputs.e2e-mirror-node-test-subdir }}
# e2e-node-pem-stop-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-test-subdir }}
# e2e-node-pfx-kill-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-test-subdir }}
# e2e-node-pem-stop-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pem-stop-test-subdir }}
# e2e-node-pfx-kill-test-subdir: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-test-subdir }}
# e2e-node-local-build-test-subdir: ${{ needs.env-vars.outputs.e2e-node-local-build-test-subdir }}
# e2e-node-add-test-subdir: ${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}
# e2e-relay-test-subdir: ${{ needs.env-vars.outputs.e2e-relay-test-subdir }}
# e2e-coverage-report: ${{ needs.env-vars.outputs.e2e-coverage-report }}
# e2e-mirror-node-coverage-report: ${{ needs.env-vars.outputs.e2e-mirror-node-coverage-report }}
# e2e-node-pem-stop-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pem-stop-add-coverage-report }}
# e2e-node-pfx-kill-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-add-coverage-report }}
# e2e-node-pem-stop-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pem-stop-coverage-report }}
# e2e-node-pfx-kill-coverage-report: ${{ needs.env-vars.outputs.e2e-node-pfx-kill-coverage-report }}
# e2e-node-local-build-coverage-report: ${{ needs.env-vars.outputs.e2e-node-local-build-coverage-report }}
# e2e-node-add-coverage-report: ${{ needs.env-vars.outputs.e2e-node-add-coverage-report }}
# e2e-relay-coverage-report: ${{ needs.env-vars.outputs.e2e-relay-coverage-report }}
# secrets:
# snyk-token: ${{ secrets.SNYK_TOKEN }}
Loading
Loading