fix: improve types in JSDoc and fix typo in '/src/commands/account.mjs' #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c/commands/account.mjs' Signed-off-by: instamenta <instamenta@abv.bg>
instamenta
changed the title
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: Jan Milenkov <instamenta@abv.bg>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: Jan Milenkov <instamenta@abv.bg>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: Jan Milenkov <instamenta@abv.bg>
jeromy-cannon
changed the title
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: Jan Milenkov <instamenta@abv.bg>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: Jan Milenkov <instamenta@abv.bg>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: Jan Milenkov <instamenta@abv.bg>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: Jan Milenkov <instamenta@abv.bg>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com> Signed-off-by: Jan Milenkov <instamenta@abv.bg>
jeromy-cannon
previously approved these changes
Sep 3, 2024
Signed-off-by: instamenta <instamenta@abv.bg>
Signed-off-by: instamenta <instamenta@abv.bg>
Signed-off-by: instamenta <instamenta@abv.bg>
… was before Signed-off-by: instamenta <instamenta@abv.bg>
jeromy-cannon
approved these changes
Sep 4, 2024
swirlds-automation
added a commit
that referenced
this pull request
Sep 6, 2024
## [0.29.0](v0.28.1...v0.29.0) (2024-09-06) ### Features * add local build support for node add command ([#509](#509)) ([a7e778f](a7e778f)) * add node delete and update command ([#500](#500)) ([9f8549a](9f8549a)) * use k8s secrets to store node gossip and grpc tls keys and mount them ([#499](#499)) ([ede1842](ede1842)) ### Bug Fixes * added missing async/await where needed ([#551](#551)) ([d8e5032](d8e5032)) * improve types in JSDoc and fix typo in '/src/commands/account.mjs' ([#507](#507)) ([74c9e2c](74c9e2c)) * need to update agreement key together with signing key ([#539](#539)) ([f9b2e21](f9b2e21)) * removed the custom ip address logic and '@hashgraph/proto' ([#518](#518)) ([c81c76a](c81c76a))
|
🎉 This PR is included in version 0.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
account.mjsRelated Issues