nodesim: mount cgroup host path #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR hashicorp/nomad#19915 added an explicit error check to prevent silent failures when clients are unable to properly setup cgroups. This prevents `nomad-nodesim` jobs to start unless `/sys/fs/cgroup` is available for write inside the container. Since `nomad-nodesim` doesn't run real allocations, mounting the host path _should_ be fine (famous last words).
jrasell
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR hashicorp/nomad#19915 added an explicit error check to prevent silent failures when clients are unable to properly setup cgroups.
This prevents
nomad-nodesimjobs to start unless/sys/fs/cgroupis available for write inside the container.Since
nomad-nodesimdoesn't run real allocations, mounting the host path should be fine (famous last words).