enos_vault_start: support configuring the retry_join block in storage #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support forcing `retry_join` to resolve using IPV6 we need to include the address type in the `auto_join` stanza. Historically we have handled the `retry_join` stanza in the `enos_vault_start` resource and did not have a way to define the `retry_join` block. This does just that by supporting `retry_join` in the storage schema by using a dynamic pseudo type for `storage` in the config. I've tested the resource with no `retry_join` defined and added a new variant to our test scenarios to test with it set or null. All work just fine. Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
force-pushed
the
ryan/retry-join-vault
branch
from
86dbb39 to
9c78bc2
Compare
Signed-off-by: Ryan Cragun <me@ryan.ec>
jasonodonnell
approved these changes
Jul 3, 2024
|
The failure here appears to be an issue with Terraform 1.9. We could temporarily pin to Terraform 1.8 in our tests or admin merge as it's a very subtle thing that should have minimal real impact in scenarios. |
Signed-off-by: Ryan Cragun <me@ryan.ec>
Signed-off-by: Ryan Cragun <me@ryan.ec>
Build the artifacts in parallel to speed up the build workflow and to make it easier to only download the artifacts necessary when testing. Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
force-pushed
the
ryan/retry-join-vault
branch
from
67ba79f to
0f54acb
Compare
Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
force-pushed
the
ryan/retry-join-vault
branch
from
0f54acb to
9cee3bb
Compare
Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
force-pushed
the
ryan/retry-join-vault
branch
from
c4b116a to
78ffeca
Compare
Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
force-pushed
the
ryan/retry-join-vault
branch
from
ab6f644 to
cafab63
Compare
…before running tests Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
force-pushed
the
ryan/retry-join-vault
branch
from
1792729 to
adc56ed
Compare
ryancragun
commented
Jul 11, 2024
|
|
||
| resource "aws_instance" "remotehost" { | ||
| ami = data.aws_ami.ubuntu.id | ||
| instance_type = "t3.small" |
There was a problem hiding this comment.
Some tests were flaky because they connect to this machine. I boosted the size to give it more CPU credits.
ryancragun
commented
Jul 11, 2024
| } | ||
|
|
||
| resource "enos_remote_exec" "wait" { | ||
| inline = ["sudo cloud-init status --wait"] |
There was a problem hiding this comment.
I also added this so our tests timeout while waiting for the instance to actually be available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to read this pull request
In order to support forcing
retry_jointo resolve using IPV6 we needto include the address type in the
auto_joinstanza. Historically wehave handled the
retry_joinstanza in theenos_vault_startresourceand did not have a way to define the
retry_joinblock.This does just that by supporting
retry_joinin the storage schema byusing a dynamic pseudo type for
storagein the config.I've tested the resource with no
retry_joindefined and added a newvariant to our test scenarios to test with it set or null. All work just
fine.
Along the way I also updated our linter configuration and resolved new issues.
I also updated most Go deps. We are not on the latest
terraform-plugin-gobecause it requires new updates to the server to support provider functions.
Checklist