Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve region from IMDS when initial credentials retrieved from IMDS #131

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Retrieve region from IMDS when initial credentials retrieved from IMDS #131

merged 4 commits into from
Feb 23, 2022

Conversation

gdavison
Copy link
Contributor

Retreives region from IMDS when initial credentials retrieved from IMDS

Closes #113

Relates hashicorp/terraform-provider-aws#23321

@gdavison gdavison requested a review from a team as a code owner February 23, 2022 00:13
ewbankkit
ewbankkit approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test .                    
ok  	github.com/hashicorp/aws-sdk-go-base/v2	1.841s

@gdavison gdavison merged commit f7aad69 into main Feb 23, 2022
@gdavison gdavison deleted the region-from-imds branch February 23, 2022 18:12
gdavison added a commit that referenced this pull request Feb 23, 2022
@gdavison
Updates CHANGELOG for #131
72c9b6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configuration: When authenticating via IMDS also potentially retrieve region from IMDS
2 participants
@gdavison @ewbankkit