Implement configuration assume role duration, policy ARNs, tags, and transitive tag keys #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure we have all the latest and greatest STS features and prevent any confusion over the AWS Go SDK version minimum in this libary. Updated via: ``` go get github.com/aws/aws-sdk-go@v1.31.9 go mod tidy ```
Otherwise, the updated AWS Go SDK EC2 Metadata client would return errors against the mock server. ``` === RUN TestGetSession/EC2_metadata_access_key 2020/06/02 19:07:53 [INFO] Attempting to use session-derived credentials 2020/06/02 19:07:53 [INFO] Setting custom EC2 metadata endpoint: http://127.0.0.1:60498/latest 2020/06/02 19:07:53 [DEBUG] Mock EC2 metadata server received request: /latest/api/token 2020/06/02 19:07:53 [DEBUG] Mock EC2 metadata server received request: /latest/api/token 2020/06/02 19:07:53 [DEBUG] Mock EC2 metadata server received request: /latest/api/token 2020/06/02 19:07:53 [INFO] Attempting to use metadata-derived credentials 2020/06/02 19:07:53 [INFO] Setting AWS metadata API timeout to 100ms 2020/06/02 19:07:53 [INFO] Setting custom metadata endpoint: "http://127.0.0.1:60498/latest" 2020/06/02 19:07:53 [DEBUG] Mock EC2 metadata server received request: /latest/api/token 2020/06/02 19:07:53 [DEBUG] Mock EC2 metadata server received request: /latest/api/token 2020/06/02 19:07:53 [DEBUG] Mock EC2 metadata server received request: /latest/api/token 2020/06/02 19:07:53 [DEBUG] Mock EC2 metadata server received request: /latest/api/token 2020/06/02 19:07:53 [INFO] Ignoring AWS metadata API endpoint at http://127.0.0.1:60498/latest as it doesn't return any instance-id TestGetSession/EC2_metadata_access_key: session_test.go:1013: expected no error, got error: No valid credential sources found for AWS Provider. Please see https://terraform.io/docs/providers/aws/index.html for more information on providing credentials for the AWS Provider ```
bflad
force-pushed
the
f-assume-role-additional-configurations
branch
from
2355871 to
c1af854
Compare
bflad
added a commit
that referenced
this pull request
Jun 15, 2020
…nd transitive tag keys Reference: #39
bflad
added a commit
that referenced
this pull request
Jul 7, 2020
…ume role testing (#45) * Create and export constants to simplify mock handling Allows downstream codebases to reuse the mocking framework. * Add GetSession() testing for assume role policy, policy ARNs, tags, and transitive tag keys Reference: #39 * Remove now extraneous stsResponse_GetCallerIdentity_valid_expectedPartition constant
PhillipGameDev
added a commit
to PhillipGameDev/AWS-SDK-GO-BACKEND
that referenced
this pull request
Dec 10, 2024
…ume role testing (#45) * Create and export constants to simplify mock handling Allows downstream codebases to reuse the mocking framework. * Add GetSession() testing for assume role policy, policy ARNs, tags, and transitive tag keys Reference: hashicorp/aws-sdk-go-base#39 * Remove now extraneous stsResponse_GetCallerIdentity_valid_expectedPartition constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #11
Closes #21
Closes #34
AWS Go SDK version increase to current latest to ensure we have a version with these STS features.
Updated via: