V2: Enables more authentication #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this depend on #71 to eliminate the |
ewbankkit
reviewed
Sep 8, 2021
Comment on lines
+81
to
+84
| // FIXME: This should only be set for retrieving Creds | ||
| config.WithRetryer(func() aws.Retryer { | ||
| return aws.NopRetryer{} | ||
| }), |
There was a problem hiding this comment.
Does this mean that no retries are attempted for any service?
There was a problem hiding this comment.
For now, though it will be only when retrieving credentials. I'm currently doing some refactoring to resolve that
Yes |
gdavison
force-pushed
the
more-authentication
branch
from
9c6c8ca to
bedc838
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables additional authentication configurations