Fix minor regression on custom User-Agent #990
Merged
+60
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: #0000 <!--- Pull Requests should have an associated issue or may be closed --->
Please briefly describe the changes proposed in this pull request.
Since version 1.19 of
aws-sdk-go-v2, some special characters in User-Agent strings are being escaped (aws/aws-sdk-go-v2#2154). Inaws-sdk-go-base, the handling of User-Agent strings has been updated in #554, but as forTF_APPEND_USER_AGENTit's still appended with theaws-sdk-go-v2implementation. This has led to a regression in our usage ofterraform-provider-awsbecause of the presence of a/character in ourTF_APPEND_USER_AGENT. While it might sound like an edge case, but I'd appreciate it ifTF_APPEND_USER_AGENTis appended as it used to be!