Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat Conditions with empty array values as empty string values #8

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Treat Conditions with empty array values as empty string values #8

merged 1 commit into from
Jan 12, 2022

Conversation

ewbankkit
Copy link
Collaborator

Relates: hashicorp/terraform-provider-aws#22505.

Without the fix:

% go test -v .
=== RUN   TestPolicyEquivalence
    aws_policy_equivalence_test.go:300: Bad: Condition containing empty array
          Expected: true
               Got: false
--- FAIL: TestPolicyEquivalence (0.00s)
=== RUN   TestStringValueSlicesEqualIgnoreOrder
--- PASS: TestStringValueSlicesEqualIgnoreOrder (0.00s)
FAIL
FAIL	github.com/hashicorp/awspolicyequivalence	0.924s
FAIL

YakDriver
YakDriver approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy bien! 🎉

@ewbankkit ewbankkit merged commit bd206d4 into main Jan 12, 2022
@ewbankkit ewbankkit deleted the b-condition-with-empty-array branch January 12, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @YakDriver