Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credential Rotation #13

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Credential Rotation #13

merged 4 commits into from
Apr 4, 2024

Conversation

hugoghx
Copy link
Contributor

@hugoghx hugoghx commented Mar 22, 2024

No description provided.

@hugoghx hugoghx requested review from louisruch and kheina March 22, 2024 15:20
@hugoghx hugoghx self-assigned this Mar 22, 2024
louisruch
louisruch approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@louisruch louisruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait fro Dani to do a full review before merging

kheina
kheina requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@kheina kheina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic tests, as always

plugin/service/storage/attributes_test.go Outdated Show resolved Hide resolved
plugin/service/storage/plugin.go Outdated Show resolved Hide resolved
plugin/service/storage/plugin.go Outdated Show resolved Hide resolved
plugin/service/storage/plugin.go Show resolved Hide resolved
plugin/service/storage/rotation.go Outdated Show resolved Hide resolved
plugin/service/storage/rotation.go Outdated Show resolved Hide resolved
plugin/service/storage/plugin.go Outdated Show resolved Hide resolved
plugin/service/storage/plugin_test.go Outdated Show resolved Hide resolved
kheina
kheina approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@kheina kheina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hugoghx hugoghx force-pushed the hugo-cred-rotation branch from 352f3a3 to d46ce4b Compare April 4, 2024 16:55
@hugoghx hugoghx merged commit bde78ec into main Apr 4, 2024
2 checks passed
@hugoghx hugoghx deleted the hugo-cred-rotation branch April 4, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisruch louisruch louisruch approved these changes

@kheina kheina kheina approved these changes

Assignees

@hugoghx hugoghx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugoghx @louisruch @kheina