-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade node engines to work with node 20 and 22 #2486
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Since node 21 is already past it's maintenance window, should we try going straight to v22 instead? |
should we also consider using the same version in boundary-ui-releases? |
Good point. Some thinking loud:
is that correct? |
Correct. If we are going to upgrade our supported node version, we should probably stick to the LTS versions. Plus v22 doesn't start it's maintenance schedule until a year from now. So this should hold us for a while. |
Awesome!! pushing changes 😃 |
We keep supporting node 20. For now, I will suggest to keep the pipeline with node 20. Upgrading node in the pipeline requires more work, specially testing. We just upgrade the pipeline from 18 to 20 so IMHo its fine for a while. Thoughts? |
that sounds good! |
@DhariniJeeva |
5e950f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calcaide did you run a script to update node v in different files, or was this manual? Just wondering how we handle upgrades.
I did perform this manually. This PR updates the engines key within package.json, it will be developer responsability to upgrade acordingly the node version use within the dev enviornment. |
UPDATE Friday January 31: Tested this changes on the
boundary-deskto-releases
successfuly, here the run.Description
Upgrade node engines to work with node 20 and 22.