Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icu 15471 credential store tests #2663

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Icu 15471 credential store tests #2663

wants to merge 7 commits into from
+215 −178

Conversation

cameronperera
Copy link
Collaborator

Description

This is for the remaining RUDL tests of credential stores

Read 🎟️ Jira ticket
Update 🎟️ Jira ticket
Delete 🎟️ Jira ticket
List 🎟️ Jira ticket

Screenshots (if appropriate)

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@cameronperera cameronperera self-assigned this Jan 23, 2025
@cameronperera cameronperera requested a review from a team as a code owner January 23, 2025 23:55
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 3:28pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 3:28pm

calcaide
calcaide reviewed Jan 29, 2025
View reviewed changes
ui/admin/tests/helpers/selectors.js
@@ -43,6 +43,8 @@ export const MODAL_WARNING_CANCEL_BTN =
export const MODAL_WARNING_TITLE = '.hds-modal__header';
export const MODAL_WARNING_MESSAGE = '.hds-modal__body';

// Search filtering selectors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None blocking comment: within the auth-method refactor, I add a similar selector but at the auth-method domain level.
I knew sooner or alter we will have to make it as common, so I will refactor that to use this one! Thanks!

calcaide
calcaide previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!!! one more domain done like a champ ✅

DhariniJeeva
DhariniJeeva previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cameronperera cameronperera changed the base branch from main to post-release/0.19.x February 3, 2025 15:43
@cameronperera cameronperera changed the base branch from post-release/0.19.x to main February 4, 2025 21:57
@cameronperera cameronperera dismissed stale reviews from DhariniJeeva and calcaide February 4, 2025 21:57

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcaide calcaide calcaide left review comments

@DhariniJeeva DhariniJeeva DhariniJeeva left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@cameronperera cameronperera

Labels
admin ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cameronperera @calcaide @DhariniJeeva