This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Bug: LoadBalancers - Use Hostnames in addition to IP #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This adds hostname values to addresses for a loadbalancer. In particular this is necessary for AWS EKS. In EKS LoadBalancers get "ExternalP" values that aren't actually IP addresses, but rather are hostnames. This is accounted for in the underlying
Service.Status.LoadBalancer.Ingress[*].Hostname
fields.The problem is two-fold. In EKS LoadBalancer have hostnames rather than ips, so we:
This was resulting in the following error:
The fix is to:
How I've tested this PR:
Unit tests and verified the bug and fix on EKS with a test image pushed to
public.ecr.aws/d1c7c4d0/testing123:1
.