Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy tags from the AWS service instance to Consul #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

remilapeyre
Copy link

Since tags in AWS are a pair "key": "value", both parts are concatenated
before being saved in the Consul catalog. When a tag gets updated on AWS
the associated service on Consul gets updated in place with the new
value to false triggers.

This only sync tags from ECS tasks but it should be easy to expand the
scope as needed.

The synchronisation only goes from AWS to Consul as I'm not sure there
is a place to store additional tags to a service instance in Cloud Map.

Since tags in AWS are a pair "key": "value", both parts are concatenated
before being saved in the Consul catalog. When a tag gets updated on AWS
the associated service on Consul gets updated in place with the new
value to false triggers.

This only sync tags from ECS tasks but it should be easy to expand the
scope as needed.

The synchronisation only goes from AWS to Consul as I'm not sure there
is a place to store additional tags to a service instance in Cloud Map.
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 4, 2019

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Rémi Lapeyre seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@larstobi
Copy link

@i0rek I've found consul-aws to be quite useful, but it hasn't been updated for 5 months. Is this project still alive?

@hanshasselberg
Copy link
Member

@larstobi Currently I don't have time to work on this project. But this project is not abandoned, I just didn't have time to do anything, but I am trying to find ways so that this project gets the love it deservers :).

@chris-peterson
Copy link

would it be possible to implement this using cloudmap APIs exclusively? I don't think cloudmap services/instances initially supported tags, but they do now. bringing in the ECS dependency presents encapsulation issues (e.g. if you're using EC2/K8s, etc) as well as IAM issues (the underlying hosts need additional permissions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants