-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for namespaces and adminPartitions #42
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your work. My comments are no blockers, but I think it would be nice if Namespace
and Partition
are consistently (in CatalogDeregistration
and CatalogRegistration
or in AgentService
) set only once across this PR.
@hanshasselberg Thanks for the review. I removed the additional
I guess we should have |
This PR
-consul-namespace
and-consul-admin-partition
flags to the existingconsul-aws
command. This will enable Consul enterprise users to sync their AWS to custom namespaces and admin partitions and vice versa. The default value for both these fields is an empty string and so there should be no changes in experience for non enterprise use cases.-aws-prefix
flag is non empty. Because of this bug, the existing integration test was a bit flakyGo
version of this repo to1.20