Autodetection #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should also take 469c735. Currently the service address and port are blank, all the info is in the ServiceMeta section instead. The changes I've made mean one could do: $ consul-aws sync-catalog -to-consul -aws-service-prefix=aws_ -aws-namespace elasticache
$ dig +short aws_foo.service.consul
foo.xxxxxx.0001.usw2.cache.amazonaws.com.
172.42.42.242
There is some weirdness with the phony consul-aws node having a fake ip but I don't really see the harm in that. I think these changes are in the spirit of what this this tool is trying to accomplish, certainly fits my use case very well now but I'd love to hear your thinking around this. |
|
Thank you for your work @Zilman! I will review them end of this week or beginning of next week since it requires some testing on my side. |
|
@i0rek any updates on this? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per aws/aws-sdk-go#1103 the AWS SDK leaves it up to users to set or discover the region if AWS_REGION is not set. This is convenient so I've added it.
Additionally I've added an
aws-namespaceflag so you can specify the namespace via a human readable name and it sets aws-namespace-id for you if it finds it.