Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net 2898, graceful_startup #239

Merged
merged 18 commits into from
Aug 23, 2023
Merged

net 2898, graceful_startup #239

merged 18 commits into from
Aug 23, 2023

Conversation

trevorLeonHC
Copy link
Contributor

Adding graceful_startup endpoint and function that will be called by dataplane postStart hook. Graceful_startup will block all other containers from starting up until envoy dataplane is determined to be ready.

@trevorLeonHC trevorLeonHC self-assigned this Aug 11, 2023
@trevorLeonHC trevorLeonHC requested a review from a team as a code owner August 11, 2023 19:47
@t-eckert
Copy link
Contributor

@trevorLeonHC, you'll need to add a file 239.txt to the .changelog folder following the existing conventions. Give it a shot and I'll add notes if there are any changes you need to make.

https://github.com/hashicorp/consul-dataplane/tree/main/.changelog

@t-eckert
Copy link
Contributor

You have a few unit tests to clean up. Because the /graceful_startup is now set as a default configuration. The configuration tests that are looking at the default values are failing because they expect "" and are getting "/graceful_startup".

pkg/consuldp/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is looking pretty great! I have a few requests but I am not too sure about the loop thing.

pkg/consuldp/config.go Outdated Show resolved Hide resolved
pkg/consuldp/lifecycle.go Outdated Show resolved Hide resolved
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few non-blocking comments. Great work on getting code into production!

Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you covered everything I suggested. Good job!

@zalimeni
Copy link
Member

Removing backport labels for clarity as this feature was not backported (exists in 1.3.x+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants