-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net 2898, graceful_startup #239
Conversation
@trevorLeonHC, you'll need to add a file https://github.com/hashicorp/consul-dataplane/tree/main/.changelog |
You have a few unit tests to clean up. Because the |
2c8f08c
to
595a43e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is looking pretty great! I have a few requests but I am not too sure about the loop thing.
6a57d91
to
7d76013
Compare
30b0b2b
to
90ec82c
Compare
split lifecycle tests into separate startup/shutdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few non-blocking comments. Great work on getting code into production!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you covered everything I suggested. Good job!
Removing backport labels for clarity as this feature was not backported (exists in 1.3.x+) |
Adding graceful_startup endpoint and function that will be called by dataplane postStart hook. Graceful_startup will block all other containers from starting up until envoy dataplane is determined to be ready.